-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Search to menu #41
Comments
@DavidScottBernstein @wunluv please follow the instructions above and then post here to let everyone know that you've done so. :-) |
@rgilman I'm a bit confused about what step 2 means. I see the page Site-Wide Activity at the bottom of Pages in Wordpress but I'm not sure what you mean by "add that to the end of bfcom-main-menu." |
Apologies for not being as clear as I might have been. Here's a screenshot: In it, I have checked the checkbox for Site-Wide Activity. The next step is to click the "Add to Menu" button. Once added, the lower part of the menu list will look like this: Click the little disclose triangle next to the word "Page" on the right. The panel will open to look like this: Change the "Navigation Label" from Site-Wide Activity to Search. The end result should look like this: Once you've done all of that, remember to "Save Menu" (blue buttons on the right of the screen). Hope that helps. |
Yes, big help. Thank you. Done. |
Done! @DavidScottBernstein would you be up for adding a search icon to that new menu icon, just like you did with the others? |
Yes. However, I don’t see a search menu item after I made the above change in Wordpress. |
@DavidScottBernstein do you mean that you don't see it on bfn.context.org or that you don't see it on your local dev site? As for bfn.context.org, that was my oversight. I've now added the Search menu. I also activated the footer menu. |
@rgilman I didn't see Search on either. Now I see it in the top menu on bfn.context.org but still not on my local site after I fetched from Master. |
Hmm... Curious. The inclusion of Search in the menu should be controlled by the database and not the theme files so I'm puzzle about why it's disappeared from you local site. In any case, I suggest you go back to Admin > Dashboard > Appearance > Menus to see what's going on and redo the above procedure if need be. |
@DavidScottBernstein Sounds like maybe you never fully got the search menu on in the first place? Perhaps you missed one of the steps in the instructions above? Anyway, yes, trying again sounds like a good idea. Keep in mind that it's controlled entirely by what you do in the admin and should have nothing to do with the code. |
Okay, @DavidScottBernstein has added the search icon to the menu as part of #57. The one remaining thing is for @wunluv to make the change on his local setup and confirm here. |
At some point we will need to get search functioning on the site but for now we just need a placeholder in the top menu.
Since the top menu uses WordPress's Appearance > Menus functionality, each one of us needs to do this manually (for now). Here's what I've done.
You could point this menu to any page you like – for now it's just a placeholder.
Once added, we can include it in our design work for both desktop and mobile.
The text was updated successfully, but these errors were encountered: