Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Search to menu #41

Open
rgilman opened this issue Sep 29, 2018 · 11 comments
Open

Add Search to menu #41

rgilman opened this issue Sep 29, 2018 · 11 comments
Assignees

Comments

@rgilman
Copy link
Member

rgilman commented Sep 29, 2018

At some point we will need to get search functioning on the site but for now we just need a placeholder in the top menu.

Since the top menu uses WordPress's Appearance > Menus functionality, each one of us needs to do this manually (for now). Here's what I've done.

  1. Go to https://dev.bfcom.local/wp-admin/nav-menus.php or Dashboard > Appearance > Menus – however you like to think about it.
  2. Under Pages, choose View All and find Site-Wide Activity and add that to the end of bfcom-main-menu.
  3. Once added, open that menu pane and change the name to Search.
  4. Save it.

You could point this menu to any page you like – for now it's just a placeholder.

Once added, we can include it in our design work for both desktop and mobile.

@iangilman
Copy link
Member

@DavidScottBernstein @wunluv please follow the instructions above and then post here to let everyone know that you've done so. :-)

@DavidScottBernstein
Copy link
Collaborator

@rgilman I'm a bit confused about what step 2 means. I see the page Site-Wide Activity at the bottom of Pages in Wordpress but I'm not sure what you mean by "add that to the end of bfcom-main-menu."

@rgilman
Copy link
Member Author

rgilman commented Oct 1, 2018

Apologies for not being as clear as I might have been.

Here's a screenshot:

screen shot 2018-10-01 at 1 27 44 pm

In it, I have checked the checkbox for Site-Wide Activity. The next step is to click the "Add to Menu" button.

Once added, the lower part of the menu list will look like this:

screen shot 2018-10-01 at 1 32 32 pm

Click the little disclose triangle next to the word "Page" on the right. The panel will open to look like this:

screen shot 2018-10-01 at 1 32 48 pm

Change the "Navigation Label" from Site-Wide Activity to Search. The end result should look like this:

screen shot 2018-10-01 at 1 33 01 pm

Once you've done all of that, remember to "Save Menu" (blue buttons on the right of the screen).

Hope that helps.

@DavidScottBernstein
Copy link
Collaborator

Yes, big help. Thank you. Done.

@iangilman
Copy link
Member

Done!

@DavidScottBernstein would you be up for adding a search icon to that new menu icon, just like you did with the others?

@iangilman iangilman removed their assignment Oct 3, 2018
@DavidScottBernstein
Copy link
Collaborator

Yes. However, I don’t see a search menu item after I made the above change in Wordpress.

@rgilman
Copy link
Member Author

rgilman commented Oct 3, 2018

@DavidScottBernstein do you mean that you don't see it on bfn.context.org or that you don't see it on your local dev site? As for bfn.context.org, that was my oversight. I've now added the Search menu. I also activated the footer menu.

@DavidScottBernstein
Copy link
Collaborator

@rgilman I didn't see Search on either. Now I see it in the top menu on bfn.context.org but still not on my local site after I fetched from Master.

@rgilman
Copy link
Member Author

rgilman commented Oct 3, 2018

Hmm... Curious. The inclusion of Search in the menu should be controlled by the database and not the theme files so I'm puzzle about why it's disappeared from you local site. In any case, I suggest you go back to Admin > Dashboard > Appearance > Menus to see what's going on and redo the above procedure if need be.

@iangilman
Copy link
Member

@DavidScottBernstein Sounds like maybe you never fully got the search menu on in the first place? Perhaps you missed one of the steps in the instructions above? Anyway, yes, trying again sounds like a good idea. Keep in mind that it's controlled entirely by what you do in the admin and should have nothing to do with the code.

@iangilman
Copy link
Member

Okay, @DavidScottBernstein has added the search icon to the menu as part of #57.

The one remaining thing is for @wunluv to make the change on his local setup and confirm here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants