-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏗️ Upgrade to Nuxt 3 #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33.
Oooook, this is a big one. The big picture is an upgrade from Nuxt 2 to 3 (and by proxy an upgrade from Vue 2 to 3).
As the migration documents note, "Nuxt 3 is a complete rewrite of Nuxt 2, and also based on a new set of underlying technologies." Hence, upgrading touched nearly every part of the application.1
Going granular on all of my changes would take me a long time, and I don't know that anyone is particularly keen on that level of detail. But some of the major changes include:
@nuxtjs/auth-next
fornuxt-auth-utils
for auth0 authentication. (This actually took the most time because the Nuxt 3 tooling for authentication was / is still under active development when I started this work, and the documentation on how to implement it is relatively sparse.).env
, Dockerized on Azure.Now that this repo has been upgraded to Nuxt 3, we can (1) create a shared module library in Nuxt 3 for usage across the GC Nuxt apps, and (2) upgrader the other Nuxt 2 application, GuardianConnector Views, which will take much less time since the hard lifting has been done here.
What I'm not doing here:
Supporting building Docker images for arm in the Github workflows. Something about the refactor, or maybe the upgrade of the Docker image Node version, was breaking
arm64
,arm/v7
builds. So we'll have to figure that out later for Kakawa integration @luandro (moreso important for GuardianConnector Views than this repo).Footnotes
I don't have the reference handy, but at some point I watched a video of a presentation by Evan You, the creator of Vue.js & Vite, where he described that upgrades moving forward will be much less painful, thankfully. ↩