Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable Tx Outcome Checks #1521

Open
DavePearce opened this issue Nov 19, 2024 · 3 comments · Fixed by #1522 · May be fixed by #1566
Open

Reenable Tx Outcome Checks #1521

DavePearce opened this issue Nov 19, 2024 · 3 comments · Fixed by #1522 · May be fixed by #1566
Assignees
Labels
bug Something isn't working

Comments

@DavePearce
Copy link
Collaborator

The goal here is to undo the temporary fix in #1520. The problem is that a change in the BESU version (which fixed a bug with traceEndTransaction) has meant that all recorded tx outcomes are potentially invalid with respect to e.g. the sender. The temporary fix in #1520 simply disabled tx outcome checks. The goal now is to update the recorded tx outcome information so that the tests will pass with outcome checking enabled.

@DavePearce DavePearce self-assigned this Nov 19, 2024
@DavePearce DavePearce added the bug Something isn't working label Nov 19, 2024
@letypequividelespoubelles letypequividelespoubelles linked a pull request Nov 20, 2024 that will close this issue
@DavePearce
Copy link
Collaborator Author

@letypequividelespoubelles Why did you close this? This is my reminder to fix the outstanding problems!

@DavePearce DavePearce reopened this Nov 20, 2024
@letypequividelespoubelles
Copy link
Collaborator

sorry, my bad

@DavePearce
Copy link
Collaborator Author

DavePearce commented Nov 21, 2024

  • Include improved Capture Debugging
  • Rename existing replay files
  • Remove unused replay files
  • Check diffs
  • Copy over new replay files
  • Tag missed tests? LeosNewRanges and LeosNewRangesSplitTests
  • Test test test!

@DavePearce DavePearce reopened this Nov 24, 2024
@DavePearce DavePearce linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants