-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reenable Tx Outcome Checks #1521
Open
Labels
bug
Something isn't working
Comments
@letypequividelespoubelles Why did you close this? This is my reminder to fix the outstanding problems! |
sorry, my bad |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The goal here is to undo the temporary fix in #1520. The problem is that a change in the BESU version (which fixed a bug with traceEndTransaction) has meant that all recorded tx outcomes are potentially invalid with respect to e.g. the sender. The temporary fix in #1520 simply disabled tx outcome checks. The goal now is to update the recorded tx outcome information so that the tests will pass with outcome checking enabled.
The text was updated successfully, but these errors were encountered: