Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get-starknet-v4 metamask detection #15

Open
wants to merge 4 commits into
base: next
Choose a base branch
from

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Oct 22, 2024

Fix MetaMask Detection and Provider Handling for get-starknet

This PR fixes the detection and handling of the MetaMask provider in the get-starknet v4 integration, following the same strategy as in the get-starknet v3 implementation: provider logic detection happens in the metaMaskVirtualWallet.ts.

The hasSupport methods detects the provider and sets it as provider attribute in the object, so that when loading the wallet the provider does not need to be fetched again. If the provider is not set when loading then we try to load it again.

This PR is required to finalise the get-starknet v4 implementation on the StarkNet Snap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants