Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADIOS: int16-type particle attributes do not compile #2928

Closed
BeyondEspresso opened this issue Mar 22, 2019 · 2 comments
Closed

ADIOS: int16-type particle attributes do not compile #2928

BeyondEspresso opened this issue Mar 22, 2019 · 2 comments
Assignees
Labels
affects latest release a bug that affects the latest stable release bug a bug in the project's code component: plugin in PIConGPU plugin component: third party third party libraries that are shipped and/or linked

Comments

@BeyondEspresso
Copy link
Member

BeyondEspresso commented Mar 22, 2019

The voronoiCellId-attribute of the particle merger is an int16, which is not (yet) implemented in include/picongpu/traits/AdiosToPIC.tpp. For this reason, the current dev-branch does not compile with both particle merger and ADIOS on. It would be an easy fix to also include int16-types there. Is there any deeper reason why this should not be done?

Alternatively, I could also modify the type of the voronoiCellId-attribute in speciesAttributes.param to int32, which I have done as a quick workaround for a simulation.

Before I open a pull request, I would like to hear your opinion on which route you prefer.

@ax3l ax3l added bug a bug in the project's code component: plugin in PIConGPU plugin affects latest release a bug that affects the latest stable release component: third party third party libraries that are shipped and/or linked labels Mar 23, 2019
@ax3l
Copy link
Member

ax3l commented Mar 23, 2019

I don't think ADIOS supports int16 at all, therefore better change the voronoiCellId to int32 ... :-S

We might just exclude the attribute from file I/O? I don't think its really needed, since it's a temporary property (similar to multiMask).

Update: uh wait, ADIOS should support int16_t as adios_short (implemented as fixed size on all platforms, see ornladios/ADIOS#187). Yes, just add this trait and you should be good to go! :)

@ax3l ax3l changed the title ADIOS: int16-type particle attributes do not compile with ADIOS ADIOS: int16-type particle attributes do not compile Mar 23, 2019
@ax3l
Copy link
Member

ax3l commented Mar 25, 2019

fixed with #2929, thanks to @BeyondEspresso!

@ax3l ax3l closed this as completed Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects latest release a bug that affects the latest stable release bug a bug in the project's code component: plugin in PIConGPU plugin component: third party third party libraries that are shipped and/or linked
Projects
None yet
Development

No branches or pull requests

2 participants