ISettingsStorageHelper namespace incorrect #403
Labels
bug 🐛
An unexpected issue that highlights incorrect behavior
Good first issue 💯
Issues identified as good for first-time contributors
Comments
michael-hawker
added
the
bug 🐛
|
Looks like it was introduced here as part of the transfer from the WCT: 8b7c872#diff-e8b2ffe244c59c6c54d9a996f892c8190d6b25f91e9d4880688e72536e322f4fL7 I just noticed this migrating the WinUI branch of the Toolkit on top of the 8.0.0 .NCT release...
|
michael-hawker
added
the
Good first issue 💯
maroldo26
pushed a commit
to maroldo26/dotnet
that referenced
this issue
Sep 15, 2022
… other helpers. Issue link : CommunityToolkit#403
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Not sure how this was missed, but the ISettingsStorageHelper has a different namespace than all the other helpers here:
dotnet/CommunityToolkit.Common/Helpers/ObjectStorage/ISettingsStorageHelper.cs
Line 5 in 9d1a525
All the other helpers are
CommunityToolkit.Common.Helpers...dotnet/CommunityToolkit.Common/Helpers/ObjectStorage/IFileStorageHelper.cs
Line 8 in 9d1a525
Similarly the extension helper to it has a
.Extensions:dotnet/CommunityToolkit.Common/Extensions/ISettingsStorageHelperExtensions.cs
Line 8 in 9d1a525
Where the other extensions do not and are just part of
CT.Common.Regression
No response
Steps to reproduce
Expected behavior
Consistency in Namespace
Screenshots
No response
IDE and version
VS 2022
IDE version
No response
Nuget packages
Nuget package version(s)
8.0.0
Additional context
Not sure if there's other places to audit?
Help us help you
Yes, but only if others can assist
The text was updated successfully, but these errors were encountered: