From 173cba310a1e57964deac833641218d0746b5c2a Mon Sep 17 00:00:00 2001 From: Arlo Godfrey Date: Fri, 29 Mar 2024 16:14:35 -0500 Subject: [PATCH 1/6] Updated actions to latest version for node 20 --- .github/workflows/build.yml | 38 ++++++++++++++++++------------------- tooling | 2 +- 2 files changed, 20 insertions(+), 20 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 3e239730..24aee194 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -37,13 +37,13 @@ jobs: # Steps represent a sequence of tasks that will be executed as part of the job steps: - name: Install .NET SDK v${{ env.DOTNET_VERSION }} - uses: actions/setup-dotnet@v3 + uses: actions/setup-dotnet@v4 with: dotnet-version: ${{ env.DOTNET_VERSION }} # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - name: Checkout Repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: submodules: recursive @@ -74,7 +74,7 @@ jobs: # Steps represent a sequence of tasks that will be executed as part of the job steps: - name: Configure Pagefile - uses: al-cheb/configure-pagefile-action@v1.3 + uses: al-cheb/configure-pagefile-action@v1.4 with: minimum-size: 32GB maximum-size: 32GB @@ -90,7 +90,7 @@ jobs: Set-ItemProperty -Path 'HKLM:\SOFTWARE\Microsoft\Windows\Windows Error Reporting\LocalDumps' -Name 'DumpType' -Type DWord -Value '2' - name: Install .NET SDK v${{ env.DOTNET_VERSION }} - uses: actions/setup-dotnet@v3 + uses: actions/setup-dotnet@v4 with: dotnet-version: ${{ env.DOTNET_VERSION }} @@ -100,7 +100,7 @@ jobs: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - name: Checkout Repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: submodules: recursive @@ -199,14 +199,14 @@ jobs: if: ${{ always() && (steps.test-generator.conclusion == 'success' || steps.test-platform.conclusion == 'success') }} - name: Artifact - Diagnostic Logs - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: ${{ (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }} with: name: build-logs path: ./**/*.*log - name: Artifact - ILC Repro - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: ${{ (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }} with: name: ilc-repro @@ -221,7 +221,7 @@ jobs: echo "DUMP_FILE=$(Get-ChildItem .\CrashDumps\*.dmp -ErrorAction SilentlyContinue)" >> $env:GITHUB_OUTPUT - name: Artifact - WER crash dumps - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: ${{ (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }} with: name: CrashDumps-${{ matrix.platform }} @@ -234,7 +234,7 @@ jobs: dotnet-dump analyze ${{ steps.detect-dump.outputs.DUMP_FILE }} -c "clrstack" -c "pe -lines" -c "exit" - name: Upload Package List - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: ${{ env.IS_PR == 'false' }} with: name: nuget-list @@ -244,7 +244,7 @@ jobs: # if we're not doing a PR build (or it's a PR from a fork) then we upload our packages so we can sign as a separate job or have available to test. - name: Upload Packages as Artifacts - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: ${{ env.IS_PR == 'false' || github.event.pull_request.head.repo.full_name != github.repository }} with: name: nuget-packages-${{ matrix.platform }} @@ -266,18 +266,18 @@ jobs: steps: - name: Install .NET SDK v${{ env.DOTNET_VERSION }} - uses: actions/setup-dotnet@v3 + uses: actions/setup-dotnet@v4 with: dotnet-version: ${{ env.DOTNET_VERSION }} - name: Download Package List - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: nuget-list path: ./ - name: Download built packages for ${{ matrix.platform }} - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: nuget-packages-${{ matrix.platform }} path: ./packages @@ -310,7 +310,7 @@ jobs: dotnet nuget push "**/*.nupkg" --api-key dummy --source MainLatest --skip-duplicate - name: Upload Signed Packages as Artifacts (for release) - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: ${{ env.IS_RELEASE == 'true' }} with: name: signed-nuget-packages-${{ matrix.platform }} @@ -331,12 +331,12 @@ jobs: steps: - name: Install .NET SDK v${{ env.DOTNET_VERSION }} - uses: actions/setup-dotnet@v3 + uses: actions/setup-dotnet@v4 with: dotnet-version: ${{ env.DOTNET_VERSION }} - name: Download signed packages for ${{ matrix.platform }} - uses: actions/download-artifact@v3 + uses: actions/download-artifact@v4 with: name: signed-nuget-packages-${{ matrix.platform }} path: ./packages @@ -354,7 +354,7 @@ jobs: steps: - name: Install .NET SDK v${{ env.DOTNET_VERSION }} - uses: actions/setup-dotnet@v3 + uses: actions/setup-dotnet@v4 with: dotnet-version: ${{ env.DOTNET_VERSION }} @@ -364,7 +364,7 @@ jobs: # Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it - name: Checkout Repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 with: submodules: recursive @@ -394,7 +394,7 @@ jobs: # TODO: Do we want to run tests here? Can we do that on linux easily? - name: Artifact - Diagnostic Logs - uses: actions/upload-artifact@v3 + uses: actions/upload-artifact@v4 if: ${{ (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }} with: name: linux-logs diff --git a/tooling b/tooling index bbfd1ebf..d69de932 160000 --- a/tooling +++ b/tooling @@ -1 +1 @@ -Subproject commit bbfd1ebf32495928fbc049c92980fb2119e2a7de +Subproject commit d69de9320c9b98068ec7acc5fa6ad2a70b4ad724 From 7fbb64762581e2857d278be4bc6f6889ef525f9d Mon Sep 17 00:00:00 2001 From: Arlo Godfrey Date: Tue, 2 Apr 2024 11:31:52 -0500 Subject: [PATCH 2/6] Update submodule --- tooling | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tooling b/tooling index d69de932..d5e8008f 160000 --- a/tooling +++ b/tooling @@ -1 +1 @@ -Subproject commit d69de9320c9b98068ec7acc5fa6ad2a70b4ad724 +Subproject commit d5e8008f4e66d483465635f1651deeacbbcbca41 From 5f036e5ed6c70f6bb2e84368a5c356d08d68aab8 Mon Sep 17 00:00:00 2001 From: Arlo Godfrey Date: Tue, 2 Apr 2024 11:32:20 -0500 Subject: [PATCH 3/6] Use master branch for action darenm/Setup-VSTest --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 24aee194..75444be9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -178,7 +178,7 @@ jobs: # Run tests - name: Setup VSTest Path - uses: darenm/Setup-VSTest@v1.2 + uses: darenm/Setup-VSTest@master - name: Install Testspace Module uses: testspace-com/setup-testspace@v1 From 41404f8d38b239b457e8a7ccde3d364bf5d6dcbb Mon Sep 17 00:00:00 2001 From: Arlo Godfrey Date: Tue, 2 Apr 2024 15:15:47 -0500 Subject: [PATCH 4/6] Use specific commit hash for darenm/setup-vstest --- .github/workflows/build.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 75444be9..6dcef7c9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -178,7 +178,7 @@ jobs: # Run tests - name: Setup VSTest Path - uses: darenm/Setup-VSTest@master + uses: darenm/setup-vstest@3a16d909a1f3bbc65b52f8270d475d905e7d3e44 - name: Install Testspace Module uses: testspace-com/setup-testspace@v1 From b4a049b2a1eb2dccf40601abd8e5021532ff2c27 Mon Sep 17 00:00:00 2001 From: Arlo Godfrey Date: Tue, 2 Apr 2024 15:49:25 -0500 Subject: [PATCH 5/6] Update submodule to latest PR pointer --- tooling | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tooling b/tooling index d5e8008f..b86fc83f 160000 --- a/tooling +++ b/tooling @@ -1 +1 @@ -Subproject commit d5e8008f4e66d483465635f1651deeacbbcbca41 +Subproject commit b86fc83f1d55feacdb2c76433472ad063263a4c2 From af235b575cfb98689d5ba8748311da991c857d80 Mon Sep 17 00:00:00 2001 From: Arlo Godfrey Date: Tue, 2 Apr 2024 15:52:19 -0500 Subject: [PATCH 6/6] Update submodule to latest PR pointer --- tooling | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tooling b/tooling index b86fc83f..819a0160 160000 --- a/tooling +++ b/tooling @@ -1 +1 @@ -Subproject commit b86fc83f1d55feacdb2c76433472ad063263a4c2 +Subproject commit 819a01607310fad9bf52097423977ace4b5c372a