From 03ca1cbe0f8b6c0cbeaa60bc127611714f902c58 Mon Sep 17 00:00:00 2001
From: Poker <poker_sang@outlook.com>
Date: Thu, 28 Nov 2024 10:07:32 +0800
Subject: [PATCH] prevent floating point errors

---
 .../src/StaggeredLayout/StaggeredLayout.cs    | 21 ++++++++++---------
 .../StaggeredLayout/StaggeredLayoutState.cs   |  8 +++----
 tooling                                       |  2 +-
 3 files changed, 16 insertions(+), 15 deletions(-)

diff --git a/components/Primitives/src/StaggeredLayout/StaggeredLayout.cs b/components/Primitives/src/StaggeredLayout/StaggeredLayout.cs
index 384d0614..5391bbb7 100644
--- a/components/Primitives/src/StaggeredLayout/StaggeredLayout.cs
+++ b/components/Primitives/src/StaggeredLayout/StaggeredLayout.cs
@@ -147,7 +147,7 @@ protected override Size MeasureOverride(VirtualizingLayoutContext context, Size
             return new Size(availableSize.Width, 0);
         }
 
-        if ((context.RealizationRect.Width == 0) && (context.RealizationRect.Height == 0))
+        if (context.RealizationRect is { Width: 0, Height: 0 })
         {
             return new Size(availableSize.Width, 0.0f);
         }
@@ -174,13 +174,14 @@ protected override Size MeasureOverride(VirtualizingLayoutContext context, Size
             }
             else
             {
-                var tempAvailableWidth = availableWidth + ColumnSpacing;
+                // 0.00001 is to prevent floating point errors
+                var tempAvailableWidth = availableWidth + ColumnSpacing - 0.00001;
                 numColumns = (int)Math.Floor(tempAvailableWidth / DesiredColumnWidth);
                 columnWidth = tempAvailableWidth / numColumns - ColumnSpacing;
             }
         }
         
-        if (columnWidth != state.ColumnWidth)
+        if (Math.Abs(columnWidth - state.ColumnWidth) > double.Epsilon)
         {
             // The items will need to be remeasured
             state.Clear();
@@ -205,10 +206,10 @@ protected override Size MeasureOverride(VirtualizingLayoutContext context, Size
             state.ClearColumns();
         }
 
-        if (RowSpacing != state.RowSpacing)
+        if (Math.Abs(this.RowSpacing - state.RowSpacing) > double.Epsilon)
         {
             // If the RowSpacing changes the height of the rows will be different.
-            // The columns stores the height so we'll want to clear them out to
+            // The columns store the height so we'll want to clear them out to
             // get the proper height
             state.ClearColumns();
             state.RowSpacing = RowSpacing;
@@ -228,7 +229,7 @@ protected override Size MeasureOverride(VirtualizingLayoutContext context, Size
             {
                 // Item has not been measured yet. Get the element and store the values
                 item.Element = context.GetOrCreateElementAt(i);
-                item.Element.Measure(new Size((float)state.ColumnWidth, (float)availableHeight));
+                item.Element.Measure(new Size(state.ColumnWidth, availableHeight));
                 item.Height = item.Element.DesiredSize.Height;
                 measured = true;
             }
@@ -260,12 +261,12 @@ protected override Size MeasureOverride(VirtualizingLayoutContext context, Size
 
                 deadColumns.Add(columnIndex);
             }
-            else if (measured == false)
+            else if (!measured)
             {
                 // We ALWAYS want to measure an item that will be in the bounds
                 item.Element = context.GetOrCreateElementAt(i);
-                item.Element.Measure(new Size((float)state.ColumnWidth, (float)availableHeight));
-                if (item.Height != item.Element.DesiredSize.Height)
+                item.Element.Measure(new Size(state.ColumnWidth, availableHeight));
+                if (Math.Abs(item.Height - item.Element.DesiredSize.Height) > double.Epsilon)
                 {
                     // this item changed size; we need to recalculate layout for everything after this
                     state.RemoveFromIndex(i + 1);
@@ -282,7 +283,7 @@ protected override Size MeasureOverride(VirtualizingLayoutContext context, Size
 
         double desiredHeight = state.GetHeight();
 
-        return new Size((float)availableWidth, (float)desiredHeight);
+        return new Size(availableWidth, desiredHeight);
     }
 
     /// <inheritdoc/>
diff --git a/components/Primitives/src/StaggeredLayout/StaggeredLayoutState.cs b/components/Primitives/src/StaggeredLayout/StaggeredLayoutState.cs
index 10b567a4..02b2e08e 100644
--- a/components/Primitives/src/StaggeredLayout/StaggeredLayoutState.cs
+++ b/components/Primitives/src/StaggeredLayout/StaggeredLayoutState.cs
@@ -91,14 +91,14 @@ internal void ClearColumns()
     /// </summary>
     /// <returns>The estimated height of the layout.</returns>
     /// <remarks>
-    /// If all of the items have been calculated then the actual height will be returned.
-    /// If all of the items have not been calculated then an estimated height will be calculated based on the average height of the items.
+    /// If all the items have been calculated then the actual height will be returned.
+    /// If all the items have not been calculated then an estimated height will be calculated based on the average height of the items.
     /// </remarks>
     internal double GetHeight()
     {
-        double desiredHeight = Enumerable.Max(_columnLayout.Values, c => c.Height);
+        double desiredHeight = this._columnLayout.Values.Max(c => c.Height);
 
-        var itemCount = Enumerable.Sum(_columnLayout.Values, c => c.Count);
+        var itemCount = this._columnLayout.Values.Sum(c => c.Count);
         if (itemCount == _context.ItemCount)
         {
             return desiredHeight;
diff --git a/tooling b/tooling
index d71b08b2..e366657a 160000
--- a/tooling
+++ b/tooling
@@ -1 +1 @@
-Subproject commit d71b08b2dccf94c3ceaeda99526679bc0cfc3b8a
+Subproject commit e366657a924a745c6fb4162dc4c58d2e07fc0613