Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pausing/resuming MarqueeText #505

Open
Arlodotexe opened this issue Nov 2, 2023 · 2 comments
Open

Enable pausing/resuming MarqueeText #505

Arlodotexe opened this issue Nov 2, 2023 · 2 comments
Assignees
Labels
enhancement Improvement to an existing feature experiment 🧪 Used to track issues that are experiments (or their linked discussions) help wanted Extra attention is needed labs 🧪

Comments

@Arlodotexe
Copy link
Member

Arlodotexe commented Nov 2, 2023

From #426:

Hi, I'm using this control in my project currently,
I want to implement a feature that when the pointer entered the text start animation,
and when pointer exited, the text should be re-placed at the very begin place.
is there any way to programmatically achieve this? Or should this be a feature request?

Originally posted by @Lightczx in #426 (comment)


The resume parameter is for when the speed or control size changes while the animation is running. It is not supposed to be used for pausing or resuming the animation.

In design I intended for the Marquee to not play until StartMarquee is called. This is not the behavior because of line 56 is MarqueeText.Events link, which automatically begins the animation when the container size is changed. I should have left this behavior up to the user.

@Arlodotexe Should I release a patch? It's a technically a small breaking change.

Originally posted by @Avid29 in #426 (comment)


This is a reasonable scenario to support for MarqueeText. We should look into implementing pause/resume functionality.

@Arlodotexe Arlodotexe added enhancement Improvement to an existing feature help wanted Extra attention is needed experiment 🧪 Used to track issues that are experiments (or their linked discussions) labs 🧪 labels Nov 2, 2023
@Arlodotexe
Copy link
Member Author

@Avid29 Since you're most familiar with the codebase, would you like to submit a PR for this?

@Avid29
Copy link
Contributor

Avid29 commented Nov 2, 2023

@Avid29 Since you're most familiar with the codebase, would you like to submit a PR for this?

Can do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature experiment 🧪 Used to track issues that are experiments (or their linked discussions) help wanted Extra attention is needed labs 🧪
Projects
Status: No status
Development

No branches or pull requests

2 participants