Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Move LoginButton to be a DropDownButton #63

Open
michael-hawker opened this issue Nov 17, 2020 · 0 comments
Open

[Feature] Move LoginButton to be a DropDownButton #63

michael-hawker opened this issue Nov 17, 2020 · 0 comments
Labels
Area: Controls Controls: LoginButton enhancement ✨ New feature or request help wanted 🙋 Extra attention is needed

Comments

@michael-hawker
Copy link
Member

Describe the problem this feature would solve

Now that our min target is 1809, we can make use of DropDownButton. We should use that as a base class for the LoginButton vs. our custom button scenario/flyout.

We do need to think about how we adapt the style of a DropDownButton to encompass the user login and if we keep the default chevron, etc...
@michael-hawker michael-hawker added enhancement ✨ New feature or request help wanted 🙋 Extra attention is needed labels Nov 17, 2020
@shweaver-MSFT shweaver-MSFT added this to the 7.1.0 milestone Jun 11, 2021
@shweaver-MSFT shweaver-MSFT removed this from the 7.1.0 milestone Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Controls Controls: LoginButton enhancement ✨ New feature or request help wanted 🙋 Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michael-hawker @shweaver-MSFT