Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌐 Translations - improved translation for zh cn 20241108 #679
base: support/3.2
Are you sure you want to change the base?
🌐 Translations - improved translation for zh cn 20241108 #679
Changes from 2 commits
08dd9f7
a618749
cf55ddd
feccee9
3ab8c02
a530c51
87aa68e
57f5cfe
f4cae0d
e1fb7d5
70f48e9
5ba601d
8e83224
41aa341
a22e6f3
294f537
772dffc
9b85f8b
57d825f
de95fb4
ec1ca9b
6a0861d
cf67c61
76026ee
aedc5f1
dfb08fe
c788163
88d1072
8828ba0
46be906
c6051d9
9bd5be3
ff9e1e7
602b3f0
3bec0b9
26706e8
36bfc1e
941e113
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not nice to remove original authors. Same remark for the other files where You removed the
@author
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robert Deng is the zh cn maintainer quite many years ago,I am the main contributor of zh-cn in the recent 2 years
in my mind,the “@author” line was removed by me since itop 2.4 or 2.5
why it appears in iTop 3.2 again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
He still is the original author. Should not be removed, only add a new
@author
if needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't these items supposed to be sorted alphabetically?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please re-add the missing newline at end of file.