New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UHN-MA-21] Use relative length units for base styling #37

Open

Asiapenguin opened this issue Nov 24, 2019 · 1 comment · May be fixed by #142

Assignees

Labels

bug components high priority research required

Contributor

Asiapenguin commented Nov 24, 2019

Explore into using relative length units to define certain css params (e.g. margins/padding width/height)
- This helps the app to render correctly on different dimensions (e.g. difference in sizes of iPhones and Android phones)
- This IS NOT for tablet vs phone comparisons (these should use media queries)

Asiapenguin added research required components labels

Asiapenguin added bug high priority labels

Contributor Author

Asiapenguin commented May 13, 2020

Tai just tested the app on his device LG K4 2017 (https://www.gsmarena.com/lg_k4_(2017)-8489.php) and he is seeing overlapping components.

mxnyee self-assigned this

mxnyee linked a pull request

that will close this issue

Relative units #142

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment