Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Volume in Control Options #516

Open
BudderCobi opened this issue Jan 3, 2025 · 12 comments · May be fixed by #518
Open

Enhancement: Volume in Control Options #516

BudderCobi opened this issue Jan 3, 2025 · 12 comments · May be fixed by #518
Labels
enhancement New feature or request

Comments

@BudderCobi
Copy link

BudderCobi commented Jan 3, 2025

Add the volume buttons to the Options>Controls menu.

Just a personal request.
I like to have my back button be Numpad0 and I typically change the mute button to backspace to compensate for the whole "muting my game" thing.
(I play with arrow keys, so it makes it easier so I don't have to move my hands as much.)

@BudderCobi BudderCobi added the enhancement New feature or request label Jan 3, 2025
@r6915ee
Copy link

r6915ee commented Jan 3, 2025

I don't think it'd be THAT easy to configure the volume controls like that. The volume setter is integrated directly into HaxeFlixel, so it's likely using FlxG to check which keys are being pressed.

@FuroYT
Copy link
Member

FuroYT commented Jan 3, 2025

We have our own flixel fork remember
Even if it wasn’t implemented we could just implement it ourselves

@ItsLJcool
Copy link
Contributor

To add this all you do is just remove / add to the variable bruh
image

@ItsLJcool
Copy link
Contributor

hold up lemme make an addon for this :trollface:

@BudderCobi
Copy link
Author

BudderCobi commented Jan 3, 2025

To add this all you do is just remove / add to the variable bruh image

Might I ask what file this is? Tried looking myself, but I can't seem to find the code.
I'm not familiar with the files for Codename yet.
(If it's something I need to fork my own build of this for, then that makes more sense to why I couldn't find anything.)

@ItsLJcool
Copy link
Contributor

its base Flixel not CodenameEngine.

its found in SoundFrontEnd and FlxG.sound is the instance of that class.

@r6915ee
Copy link

r6915ee commented Jan 3, 2025

We have our own flixel fork remember Even if it wasn’t implemented we could just implement it ourselves

Ah, I somehow forgot that most of Codename Engine is using forks, so things are different. It's at least good that it can be implemented in the fork.

@ItsLJcool
Copy link
Contributor

LMAO IT FUCKING WORKS !!!!
image

Dropping addon in CodenameEngine Server

@ItsLJcool
Copy link
Contributor

Here ya go @BudderCobi

GitHub Link
Direct Addon Download

@NexIsDumb
Copy link
Member

okay what the fuck, how did we never think of adding this😭

@ItsLJcool
Copy link
Contributor

lol

@r6915ee
Copy link

r6915ee commented Jan 4, 2025

okay what the fuck, how did we never think of adding this😭

Probably because of the horse comedically shaped like Zeus. (/j)

Seriously, though, I'm also unsure.

@TechnikTil TechnikTil linked a pull request Jan 4, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants