-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
files_to_ignore #67
Comments
Running into the same issue, this functionality seems somewhat broken. |
Yes the fix for that has never been released. I believe this repository is not maintained anymore |
#71 may have corrected this problem. The config value needed to be expanded as a whitespace separated list, done here https://github.com/CodelyTV/pr-size-labeler/pull/71/files#diff-d7c80f5e143a779b6ea480fe7455d4ba2934ccd1b453062355c72f000c9e7d02R15 Now the action logic matches the unit tests. I'll keep an eye on this issue, but after issuing a new release, this should be solved |
So I'm not sure if this is a bug or this is me just not understanding how to work the yaml file but...
I have a codebase I just pushed a small PR to and it got flagged as being over 1000 lines by the pr-size-labeler
Code changes: 5 files, 235 lines
Snapshot changes: 3 files, 2358 lines
The labeler should be ignoring the snapshot files but doesn't appear to be.
I've tried both styles of config:
and
Is it something I'm doing incorrectly? Would it have an issue with deeply nested filenames? EG:
/components/Footer/__snapshots__/index.test.tsx.snap
Sorry for the noise if I'm doing something wrong!
The text was updated successfully, but these errors were encountered: