Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minification of resources #74

Open
amitness opened this issue Oct 18, 2016 · 4 comments
Open

Minification of resources #74

amitness opened this issue Oct 18, 2016 · 4 comments

Comments

@amitness
Copy link
Member

The CSS and JS of the site can be minified to speed up loading time. We'll need to research how it is done in Django.

@prashishh
Copy link
Collaborator

We can also open a PR to Wazimap. :)

@barbier
Copy link

barbier commented Oct 27, 2016

Why not use node with gulp for it?

@cliftonmcintosh
Copy link
Member

@barbier

The CSS and JavaScript are in an upstream Django project, Wazimap. Wazimap (or Django) may have a way to minify resources. If so, I think we should use that. If Wazimap does not have the ability to minify, we might consider a PR to Wazimap to add that ability.

I would suggest that this should be configurable by environment because minified JS is harder to debug than un-minified JS. In fact, we found the cause of a bug in Wazimap because we were able to debug using un-minified JS. I think we should have un-minified JS in non-production environments.

@amitness
Copy link
Member Author

Possible solution: Django Compressor suggested on the Python Users Group Nepal.

@amitness amitness self-assigned this Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants