"No response" shows up from issue template responses #59

illicitonion · 2023-06-11T12:44:05Z

Describe the bug

https://cyf-curriculum.netlify.app/fundamentals/sprints/1/backlog/ first exercise has "No response" output from issue template

We should edit out any "No response" sections from GitHub issues. In this instance, I edited it in CodeYourFuture/Course-Fundamentals#8 but it doesn't seem to update on the site. Not sure if there's some caching going on we need to flush...

SallyMcGrath · 2023-06-11T14:58:26Z

It will update - the cache is quite long - maybe 24h.

40thieves · 2023-06-11T21:28:17Z

To me it seems like we should fail the build if we get a bad response from Github? It may not be obvious if or where content is missing in this scenario - and we might not trigger a new build to (potentially) fix it for days/weeks.

However I recognise that might not be possible currently. I assume that throwing an error (or whatever Go's equivalent is) would fail the build? Can this be done from within a template? Would we need to migrate to a Hugo module (I think that's what they're called? I now can't find the relevant docs page 🙄) for this to work?

illicitonion · 2023-06-12T20:17:09Z

if we get a bad response from Github? It may not be obvious if or where content is missing in this scenario

Just to make sure we're talking about the same thing, the issue isn't that GitHub is failing a request, it's that when someone crated an issue, they did so using a form template, and if you don't answer one of the form template's questions, GitHub still includes the heading for the field, but says No response in the issue.

So content won't be missing, it's just a bit messy/misleading on the page.

We could search for this in responses from GitHub and fail the build to tell the person doing the build "You should go edit the GitHub issue text and try again" - I just made the edit locally to do this, and got the following list of included issues which have _No response_ in their body:

(118 issues)

I think if we're going to do this, though, we need a plan for avoiding people creating issues with this text, because I suspect we'll easily miss the deployment fail-looping on Netlify because of an issue creation causing problems.

Relatedly... What's our plan to ensure we force re-builds when new issues are filed @SallyMcGrath?

SallyMcGrath · 2023-06-13T09:01:09Z

"What's our plan to ensure we force re-builds when new issues are filed @SallyMcGrath?"

repeating conversation here to log it: On rebuilds, actually my general plan was just to build once a day and not worry too much about it. I guess on some level I don't want to build in expectation of instantaneous results. 😂

response: pr from Daniel #90

SallyMcGrath · 2023-06-13T13:03:07Z

I think if we're going to do this, though, we need a plan for avoiding people creating issues with this text, because I suspect we'll easily miss the deployment fail-looping on Netlify because of an issue creation causing problems.

Is the answer to this a github action or something? It isn't a Big Deal but I agree it's nicer to not have the no response text.

We could do it post hoc on our side but I think it will be fragile.

illicitonion · 2023-06-13T23:12:44Z

We could do it post hoc on our side but I think it will be fragile.

I suspect in the short term we should just do this. Fail the nightly build, make sure that notifies a useful group of people, and someone can go do a quick edit and a redeploy.

Things don't actually change that much (after initial creation) that I'd be too worried about the fragility.

If it becomes a real issue / time sink, we can work out how to automate it.

WDYT?

40thieves · 2023-06-15T20:47:22Z

Just to make sure we're talking about the same thing, the issue isn't that GitHub is failing a request, it's that when someone crated an issue, they did so using a form template, and if you don't answer one of the form template's questions

Ah apologies, I misunderstood.

But it seems that #89 will solve my concern anyway, at least based on my (Go ignorant) read of the code?

Fwiw, I also like Daniel's approach to the No response issue in the PR - presumably folks would check the build before merging. So providing an actionable error message seems like the simplest solution to me.

illicitonion · 2023-06-15T22:44:19Z

Sounds good - I'll leave this open until I do a blitz of editing the 118 issues and turn the warning into a hard error :)

illicitonion mentioned this issue Jun 12, 2023

Rework GitHub API interactions #89

Closed

illicitonion self-assigned this Jun 15, 2023

illicitonion mentioned this issue Jun 16, 2023

Error instead of warning on _No response_ #117

Merged

illicitonion closed this as completed in #117 Jun 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

"No response" shows up from issue template responses #59

"No response" shows up from issue template responses #59

illicitonion commented Jun 11, 2023

SallyMcGrath commented Jun 11, 2023

40thieves commented Jun 11, 2023

illicitonion commented Jun 12, 2023

SallyMcGrath commented Jun 13, 2023

SallyMcGrath commented Jun 13, 2023

illicitonion commented Jun 13, 2023

40thieves commented Jun 15, 2023

illicitonion commented Jun 15, 2023

"No response" shows up from issue template responses #59

"No response" shows up from issue template responses #59

Comments

illicitonion commented Jun 11, 2023

SallyMcGrath commented Jun 11, 2023

40thieves commented Jun 11, 2023

illicitonion commented Jun 12, 2023

SallyMcGrath commented Jun 13, 2023

SallyMcGrath commented Jun 13, 2023

illicitonion commented Jun 13, 2023

40thieves commented Jun 15, 2023

illicitonion commented Jun 15, 2023