Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency slf4j-simple should be in scope "provided" or "test" #139

Open
peterkittreilly opened this issue Sep 1, 2016 · 1 comment
Open

Comments

@peterkittreilly
Copy link

<dependency>
  <groupId>org.slf4j</groupId>
  <artifactId>slf4j-simple</artifactId>
  <version>1.7.12</version>
</dependency>

Is in the pom, this means that when one has 'net.code-story:http:2.104' as a dependency, one has to exclude the slf4j-simple jar.

This is not the way that libraries should use slf4j: http://www.slf4j.org/manual.html

BASIC RULE Embedded components such as libraries or frameworks should not declare a dependency on any SLF4J binding but only depend on slf4j-api. When a library declares a transitive dependency on a specific binding, that binding is imposed on the end-user negating the purpose of SLF4J. Note that declaring a non-transitive dependency on a binding, for example for testing, does not affect the end-user.

This relates to #118 - let the user configure its own logger

@peterkittreilly
Copy link
Author

Opps: I see that #23 is already tracking this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant