Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Layout Pass Protection #58

Closed
thecoolwinter opened this issue Nov 18, 2024 · 0 comments · Fixed by #57
Closed

🐞 Layout Pass Protection #58

thecoolwinter opened this issue Nov 18, 2024 · 0 comments · Fixed by #57
Assignees
Labels
bug Something isn't working

Comments

@thecoolwinter
Copy link
Contributor

thecoolwinter commented Nov 18, 2024

Description

Our layout method breaks when reentering the function while a layout pass is ongoing. This has caused bugs related to newline processing, frame changing, and more. Recently a debug assertion was added to ensure the layout pass is begun again while a pass is already in progress.

There are still a few more delegate methods that don't need protection but are still inside the protected area. These delegate methods should be safe to move outside of the protected area, as the internal data structures for line layout at the point that they are being called have been finalized.

@thecoolwinter thecoolwinter added the bug Something isn't working label Nov 18, 2024
@thecoolwinter thecoolwinter moved this from 🆕 New to 🏃‍♂️ In Progress in CodeEdit Project Nov 18, 2024
@thecoolwinter thecoolwinter self-assigned this Nov 18, 2024
@github-project-automation github-project-automation bot moved this from 🏃‍♂️ In Progress to 🏁 Complete in CodeEdit Project Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🏁 Complete
Development

Successfully merging a pull request may close this issue.

1 participant