Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Setting to Wrap lines to editor width #868

Closed
austincondiff opened this issue Dec 17, 2022 · 9 comments
Closed

✨ Setting to Wrap lines to editor width #868

austincondiff opened this issue Dec 17, 2022 · 9 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@austincondiff
Copy link
Collaborator

austincondiff commented Dec 17, 2022

Is your feature request related to a problem? Please describe.

  • CodeEditApp/CodeEditTextView#84

This issue should be worked on with the above issue.

Describe the solution you'd like

Add a setting under Text Editing that allows a user to enable or disable line wrapping within the editor.

Indented lines should wrap to set width.

Additional context

Screenshot 2022-12-17 at 4 21 05 PM

@ben-p-commits
Copy link
Contributor

@austincondiff - I'd like to nab this one.

@ben-p-commits
Copy link
Contributor

ben-p-commits commented Jan 3, 2023

Interesting- I couldn't get horizontal text wrapping to work until I commented out this line:

STTextViewController.swift:86
image

It appears to have regressed the default functionality provided by STTextView's widthTracksTextView property.

@ben-p-commits
Copy link
Contributor

Per Khan's comment on discord,

image

Will see if I wrap this work before he wraps his on adopting TK2.

@austincondiff
Copy link
Collaborator Author

Thank you for documenting this here @ben-p-commits!

@ben-p-commits
Copy link
Contributor

@austincondiff - After doing some digging, it appears that implementing functionality needed for the wrapped line indentation stepper control...

...as implied by this screencap:
image

would require some pretty sensitive changes to STTextView. Have we run into this sort of problem yet?

I can get this enhancement working with the toggle option for wrapping, but implementing the stepper setting and associated behavior in the textview itself may be better split out as a separate enhancement imo.

@austincondiff
Copy link
Collaborator Author

That is fine, we may need to create an issue in CodeEditTextView for that then in response to this issue.

@ben-p-commits
Copy link
Contributor

I'll add one. Thanks.

@ben-p-commits
Copy link
Contributor

@ben-p-commits
Copy link
Contributor

@austincondiff - this has merged and should be good to close. As mentioned before- the indenting behavior is covered in a separate issue in CodeEditTextView

@austincondiff austincondiff moved this from 🆕 New to 🏁 Complete in CodeEdit Project Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
Status: 🏁 Complete
Development

No branches or pull requests

3 participants