Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Open Graph Tag Data #222

Open
qwo opened this issue Oct 14, 2016 · 3 comments
Open

Open Graph Tag Data #222

qwo opened this issue Oct 14, 2016 · 3 comments
Labels

Comments

@qwo
Copy link
Member

qwo commented Oct 14, 2016

Since we are using server rendered react in some parts, we can set in the call or use a query selector to give specific OG data

for example okcandidate.code4hr.org?mayor=sessoms

and it would show a picture of the candidate.

Edit:

the above apprach is broken because we can't use the mayors last name like the photos, a solution is to use their unique candidateIDs instead so that the router can handle this better.

However another better solution is just to leave this up to the backend and can be revisited also below.

@qwo
Copy link
Member Author

qwo commented Oct 15, 2016

Here is the graph tags we have.

unless we want to use a flag like suggested above we would have to populate the state.

@qwo
Copy link
Member Author

qwo commented Oct 25, 2016

i put some default copy that can be found inDefault.jsx and is rendered by the server.

@qwo qwo added the bug label Nov 2, 2016
@qwo
Copy link
Member Author

qwo commented Nov 2, 2016

Besides also that the router navigation needs to be resolved, this involves also the OG specified data to be updated

OG Data is implemented However when we link to the URL, we are linking to the base instead of the current suggested.

See https://github.com/Code4HR/okcandidate/blob/33073db259077bde63ae50b07929224394aae7a1/views/Default.jsx#L30

screenshot 2016-11-02 13 32 59

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant