Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Acceptance Tests/Linting must pass before merging #186

Open
wbprice opened this issue Sep 12, 2016 · 4 comments
Open

Acceptance Tests/Linting must pass before merging #186

wbprice opened this issue Sep 12, 2016 · 4 comments
Assignees

Comments

@wbprice
Copy link
Member

wbprice commented Sep 12, 2016

CodeShip should run tests on a branch when a PR is opened so we can catch test failures and linting errors when a PR is opened.

@ghost
Copy link

ghost commented Sep 12, 2016

YUSS

On 12 September 2016 15:13:03 GMT-04:00, "W. Blaine Price" [email protected] wrote:

CodeShip should run tests on a branch when a PR is opened so we can
catch test failures and linting errors when a PR is opened.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
#186

Ryan Y.
GnuPG Key: 0x358CD775
VoIP (ZRTP-encrypted): [email protected]
IM (OTR encryption): [email protected]

@BretFisher
Copy link
Member

So we need to do this for Docker Cloud to run tests.

https://docs.docker.com/docker-cloud/builds/automated-testing/

@BretFisher
Copy link
Member

OK so Docker Cloud expects a specific compose file that tells it what tests to run and how environment should be setup for that test. I've added one to a feature branch here: https://github.com/Code4HR/okcandidate/blob/186-test-with-dockercloud/docker-compose.test.yml

Docker Cloud will autorun anything *.test.yml as a compose file, and expect a happy exit before it marks it successful.

@BretFisher
Copy link
Member

Check this out @wbprice #229

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants