This repository has been archived by the owner on Jul 16, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Arrival times #81
Open
ghost
wants to merge
20
commits into
Code4HR:master
Choose a base branch
from
unknown repository
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Arrival times #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Freeze the new dependencies so we can have a more complete build process to test the application. - Include invoke for tasks. - Include behave for acceptance testing. - Include hypothesis for property-based testing. - Include pylint for linting. Signed-off-by: Ryan Y <[email protected]>
Generate the standard pylint config and write it to .pylintrc so we have a baseline to configure pylint if we need. Signed-off-by: Ryan Y <[email protected]>
Include environment script and steps module script so we can start to work on acceptance tests to better define the application. Signed-off-by: Ryan Y <[email protected]>
Create tasks.py so we can invoke the various tasks. - Define test task to run unittest/hypothesis tests. - Define lint task to run pylint. - Define acceptance task to run behave. - Define debug task to run a local instance of the API. Signed-off-by: Ryan Y <[email protected]>
Include a section on the various invoke tasks civic hackers may run. Signed-off-by: Ryan Y <[email protected]>
Remove vim swap files so we can keep a clean git status line. Signed-off-by: Ryan Y <[email protected]>
Create the arrival times feature so we can start to define the steps and ensure a basic level of functionality. Signed-off-by: Ryan Y <[email protected]>
Switch from 4 to 2 spaces to keep with a more consistent theme for Gherkin feature files across the community. Signed-off-by: Ryan Y <[email protected]>
Include the coverage.py coverage file in the ignore list so we continue to have a clean commit status. Signed-off-by: Ryan Y <[email protected]>
Include stub files for future unit tests based on a seeming organisation of classes I think will naturally occur once we start refactoring a bit. - Comments represent thoughts, notes, not state. Don't take them too seriously. - Include package files to get tests to use implementation functions. Signed-off-by: Ryan Y <[email protected]>
Merge branch 'master' of https://github.com/Code4HR/hrt-bus-api so we can have a cleaner application source. Signed-off-by: Ryan Y <[email protected]>
Merge branch 'master' of protingumas.com:Code4HR/hrt-bus-api because git complained about a divergence of some sort. ...? Signed-off-by: Ryan Y <[email protected]>
Merge branch 'master' into arrival-times so we can start testing the possible new solution to the arrival times problem. Signed-off-by: Ryan Y <[email protected]>
Remove the copy of the GTFS handler so we can actually know what we want to test. Signed-off-by: Ryan Y <[email protected]>
Merge branch 'master' of https://github.com/Code4HR/hrt-bus-api so we can include the automatic PEP8 changes into our current codebase and ensure none of the testing facilities broke. Signed-off-by: Ryan Y <[email protected]>
Remove .pyc files with the clean target. Signed-off-by: Ryan Y <[email protected]>
Have the maximum line length go to 80 and remove docstring warnings from linting. Signed-off-by: Ryan Y <[email protected]>
Ignore Selenium output files, include dependencies and include the acceptance test Selenium browser setup using PhantomJS. Signed-off-by: Ryan Y <[email protected]>
Merge branch 'master' into arrival-times to get the latest code updates, legibility and functionality-related, into this branch. Signed-off-by: Ryan Y <[email protected]>
This mainly contains build infrastructure. |
Also, this is really not complete. Just wanted to put what I have up. I'd gladly remove the extra documentation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
0 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes since commit 4c12fd3:
Set up some of the acceptance testing (2016-03-02 20:56:13 -0500)
are available in the git repository at:
https://github.com/ryayak1460/hrt-bus-api.git arrival-times
for you to fetch changes up to b82b3c8:
Update arrival times with mainline changes (2016-04-06 10:35:38 -0400)
Ryan Y (4):
Define arrival times feature
Use standard Cucumber indentation
Include testing into arrival times
Update arrival times with mainline changes
features/arrival_times.feature | 13 +++++++++++++
features/steps/arrival_steps.py | 12 ++++++++++++
2 files changed, 25 insertions(+)
create mode 100644 features/arrival_times.feature
create mode 100644 features/steps/arrival_steps.py