add shift+space keyboard shortcuts to move up one screen #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visurf does not support the shift key as a modifier, which is why you weren't having any luck with the changes in the commit. Enabling the shift key as a modifier currently interferes with some of Visurf's other functionality, which I'll make a note of to work on later. For the time being, you can replace Also, what kind of compilation error were you getting? I never experienced one when testing your changes, so it seems to be an unrelated issue. |
adamthiede
force-pushed
the
kbshortcuts
branch
from
432ed71 to
d612092
Compare
|
I wasn't actually having issues compiling, just that the intended behavior wasn't there. I'm not quite sure how to put it into the gtk accelerators, if those are gtk- or netsurf-specific names for those functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Neosurf,
spacemoves the view one page down butShift+spacedoes not move the view one page up. Other browsers implement this feature and it feels like it would be easy to implement, but I can't figure it out. Currently this does not work.Closes #20