Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two overlapping constructors for ECCOMetadata make it hard to remember the API #226

Open
glwagner opened this issue Nov 9, 2024 · 2 comments · May be fixed by #241
Open

Two overlapping constructors for ECCOMetadata make it hard to remember the API #226

glwagner opened this issue Nov 9, 2024 · 2 comments · May be fixed by #241

Comments

@glwagner
Copy link
Member

glwagner commented Nov 9, 2024

We have two constructors for ECCOMetadata and I can't figure out what extra feature is provided by either one.

One has the syntax

ECCOMetadata(name; dates, version, dir)

and the other

ECCOMetadata(name, date, version; dir)

Can we simply decide which one we want to support and stick with that?
@simone-silvestri
Copy link
Collaborator

We can keep only the first one.

@glwagner
Copy link
Member Author

glwagner commented Nov 9, 2024

Ok, i'll make the change

glwagner added a commit that referenced this issue Nov 12, 2024
@glwagner
Eliminate second constructor for ECCO_metadata
f00ab0b 
Closes #226
@glwagner glwagner linked a pull request Nov 12, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Eliminate second constructor for ECCO_metadata CliMA/ClimaOcean.jl
2 participants
@glwagner @simone-silvestri