Mediterranean example doesn't seem to use ECCORestoring correctly

[glwagner]

Unless I am misunderstanding something, this seems wrong:

ClimaOcean.jl/examples/mediterranean_simulation_with_ecco_restoring.jl

Lines 81 to 82 in b19c13b

	FT = ECCO_restoring_forcing(temperature; architecture = GPU(), timescale = 2days)
	FS = ECCO_restoring_forcing(salinity; architecture = GPU(), timescale = 2days)

I'm not sure if there is another example of how to use ECCORestoring lying around?

[glwagner]

@simone-silvestri

[waywardpidgeon]

Yes, in main the function ECCO_restoring_forcing is missing from ECCO_restoring.jl and the inlined ECCORestoring has completely different arguments which need to be restructured. Maybe someone meant to write the former function or has already done this and not yet included it?

In the examples subdirectory the call occurs in the mediterranean_simulation_with_ecco_restoring.jl but also in two other cases,both in mesoscale_resolving_omip directory.

[glwagner]

What happened is that the source code was changed, but the example was not updated. We're still working on getting all the examples to be tested; this has been a slow process due to the computationally intensive nature of the examples. cc @navidcy

[navidcy]

The Mediterranean example is not part of the docs yet so it's not being run every time the docs are built.

ClimaOcean.jl/docs/make.jl

Lines 15 to 22 in 5a32b35

	to_be_literated = [
	"inspect_ecco_data.jl",
	"generate_bathymetry.jl",
	"generate_surface_fluxes.jl",
	"single_column_os_papa_simulation.jl",
	# "mediterranean_simulation_with_ecco_restoring.jl",
	"near_global_ocean_simulation.jl"
	]