-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consumer creation exceptions are not handled #262
Comments
That probably makes sense, but I'd want to make sure we're consistent about using Try to encapsulate errors anywhere we'd throw. In other words if we make such a change I'd rather break the API all at once rather than changing methods individually to return Try. That said I'm not really that worried about this case because most people should be using the async APIs anyway. |
@sksamuel WDYT? |
I agree with Greg. We should be either all in on Try or just use exceptions. |
I agree too. So, let's make breaking changes? |
I don't think we should break all the methods now was kind of what I was meaning unless it was a 3.0 release, but then we need pulsar to do that too. I'd be happy to add new methods / deprecate old ones. |
When creating to consume a non-exisiting namespace, the java pulsar client prints a lot of exceptions like:
This is normal, but pulsar4s should provide consumer creation in a Try. WDYT?
The text was updated successfully, but these errors were encountered: