Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed a c-node. Replaced with combined m-nodes #104

Open
wants to merge 1 commit into
base: fix-word-break-gen-50
Choose a base branch
from

Conversation

chrisdrymon
Copy link

This word is hypenated for some reason, maybe pronunciation or meter. But there's little reason to think of it as two words. The first "word" wouldn't even make sense. I combined them into a single word and made it an m node. It would be worth reviewing the attributes.

@jcuenod
Copy link
Contributor

jcuenod commented Aug 28, 2023

Thanks for drawing attention to this @chrisdrymon!

@jonathanrobie
Copy link
Contributor

For now, let's create a separate issue for each such pull request, like this one:

#103

The week after Labor Day, we will start discussing some questions about our workflow. For now, I want to avoid directly patching trees. But I don't want to lose the issue either. @jcuenod, could you please add an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants