Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.12.2] Registering Crafting Condition Factories does not allow for actual Resource Locations #5092

Closed
UpcraftLP opened this issue Aug 10, 2018 · 3 comments · May be fixed by CleanroomMC/Cleanroom#70
Closed

[1.12.2] Registering Crafting Condition Factories does not allow for actual Resource Locations #5092

UpcraftLP opened this issue Aug 10, 2018 · 3 comments · May be fixed by CleanroomMC/Cleanroom#70

Comments

@UpcraftLP
Copy link

UpcraftLP commented Aug 10, 2018 •
edited
Loading

When registering custom IConditionFactorys via a _factories.json file, there is no way to register these using a different namespace, due to CraftingHelper always prefixing the string with the current modid.

MinecraftForge/src/main/java/net/minecraftforge/common/crafting/CraftingHelper.java

Line 579 in afd6de3

ResourceLocation key = new ResourceLocation(context.getModId(), entry.getKey());

Imo this should check for a modid prefix before substituting the current modid.
@temp1011
Copy link
Contributor

Why would you want to register a condition for another mod?

@Pyrofab
Copy link
Contributor

Pyrofab commented Aug 10, 2018

It can be useful when your mod delegates registration to a library

@LexManos
Copy link
Member

This is intentional and will not change. If you MUST donlibrary stuff, then register the factory in the "library" and use the full name in the recipe itself. Thats why we force the namespaces, and load them from all mods before loading the recipes themselves. So you can depend on anothers factory.

@Ecdcaeb Ecdcaeb mentioned this issue Feb 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[5092] CraftingFactoriesRegisterEvent & Allow for actual Resource Locations Ecdcaeb/Cleanroom
4 participants
@LexManos @UpcraftLP @Pyrofab @temp1011