Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

genPatches does not check the import #69

Closed
Ecdcaeb opened this issue Feb 24, 2024 · 1 comment
Closed

genPatches does not check the import #69

Ecdcaeb opened this issue Feb 24, 2024 · 1 comment

Comments

@Ecdcaeb
Copy link
Contributor

Ecdcaeb commented Feb 24, 2024 •
edited
Loading

Is it normal?
I noticed it does not check the import when genPatches for #68 .

else:
https://github.com/CleanroomMC/Cleanroom/blob/main/patches/minecraft/net/minecraft/advancements/AdvancementRewards.java.patch#L7
@Rongmario
Copy link
Member

Yes it is as intended, you have to qualify your imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Rongmario @Ecdcaeb