Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Address Book Integration #42

Open
MattCBowman opened this issue Jan 13, 2014 · 8 comments
Open

Add Address Book Integration #42

MattCBowman opened this issue Jan 13, 2014 · 8 comments

Comments

@MattCBowman
Copy link
Member

It would be nice to be able to plug this in and have it automatically pull in the device's address book as an option. This would make the library even easier to use.

@Kozlov-V
Copy link

+1

1 similar comment
@AnthonyMDev
Copy link

+1

@AnthonyMDev
Copy link

@MattCBowman I'm implementing this right now in a project. I'll make a pull request when I finish if you would like?

@MattCBowman
Copy link
Member Author

@AnthonyMDev - we'd love to get this implemented. I want to loop in @mhupman because he had some really good thoughts about making it so we could use the other cocoapods that deal specifically with the address book api (which is a lot to learn for very little gain).

@mhupman
Copy link
Member

mhupman commented Sep 13, 2014

@AnthonyMDev The thought was that the AddressBook integration would be part of a CocoaPods subspec. That way, if someone wanted to use MBContactPicker without importing the AddressBook framework, they could (e.g. pod 'MBContactPicker/Core' instead of pod 'MBContactPicker'.

That said, don't feel like you have to do the podspec work if you don't want to - if you can get the AddressBook integration working we can probably finish the podspec part.

@AnthonyMDev
Copy link

Alright, well, I began work on this the other day, but then I realized that Apple changed the Address Book API pretty drastically for iOS8. It's become much, much easier to use.

@MattCBowman Do you have a Cocoapod specifically in mind that you would like to use for Address Book integration? Otherwise, I will just re-create this using the new APIs when I get a chance.

@mhupman I'd be happy to do the podspec work once I've got it working. I need some more experience with creating supspecs (I've only done it once as of now).

Do we want to just dump the address book into an array and create Contact Objects?

I'll create a fork and let you know what I come up with.

@fraggle222
Copy link

Hey sorry for the noob comment here, but really does this control not have an easy way to pull contacts from the address book? Isn't that the entire point? I must be missing something.

@mhupman
Copy link
Member

mhupman commented Dec 2, 2014

No, thats what this PR is for. Honestly, the use-case of using a data source that isn't AddressBook (e.g., user accounts) seems more common, so we didn't include AddressBook integration from the outset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants