[Feature] #65 Scroll to top when Chart category changed (#67)

<!--- 
Pull Request title must contains Category, issue number, issue
description
(e.g. "[Feature] #123 Adding new Gestures")
-->

### Describe
New feature when changing category 

### Changes Made
Scroll automatically go to top when category changed


### Issues Resolved
- #65 
<!-- 
If this pull request addresses or closes any related issues, mention
them here. Use the GitHub issue linking format
(e.g., "Feature #123"). 
-->

### Additional context
Issue related to Refresh control is found & created:
- #66

MovieApp/MovieApp/Domain/Service/APIService.swift

@@ -19,7 +19,7 @@ class APIService {
 
         let task = URLSession(configuration: .default).dataTask(with: urlString) { (data, response, error) in
 
-            print("Request \(urlString.absoluteString)")
+            print("[Request] \(urlString.absoluteString)")
             if let error = error {
                 print("Error: \(error.localizedDescription)")
                 onComplete(.failure(error))
@@ -42,11 +42,14 @@ class APIService {
         return Observable.create { emitter in
 
             fetchRequest(url: url, retries: retries) { result in
+                print("---------------------------\n[Response] \(url)")
                 switch result {
                 case .success(let data):
+                    print("Success \(String(decoding: data, as: UTF8.self))")
                     emitter.onNext(data)
                     emitter.onCompleted()
                 case .failure(let error):
+                    print("Error: \(error.localizedDescription)")
                     emitter.onError(error)
                 }
             }

MovieApp/MovieApp/Domain/Utils/Cache/Cache.swift

@@ -24,7 +24,6 @@ final class Cache<Key: Hashable, Value> {
     func insertValue(_ value: Value, forKey key: Key) {
         let entry = Entry(value)
         data.setObject(entry, forKey: WrappedKey(key))
-        print("\(String(describing: Value.self)) data Cached for key: \(key)")
     }
 
     /**
@@ -34,7 +33,6 @@ final class Cache<Key: Hashable, Value> {
     */
     func value(forKey key: Key) -> Value? {
         let entry = data.object(forKey: WrappedKey(key))
-        print("Get cached data type: \(String(describing: Value.self))\n value: \(String(describing: entry?.value))")
         return entry?.value
     }
 
@@ -44,7 +42,6 @@ final class Cache<Key: Hashable, Value> {
     */
     func removeValue(forKey key: Key) {
         data.removeObject(forKey: WrappedKey(key))
-        print("\(String(describing: Value.self)) data removed for key: \(key)")
     }
 }
 

MovieApp/MovieApp/Presentation/ChartView/View/ChartViewController.swift

@@ -54,12 +54,16 @@ class ChartViewController: UIViewController {
 
         self.view.backgroundColor = UIColor(named: UIColor.background)
         self.view.addSubview(tableView)
+        self.tableView.separatorStyle = .none
         self.tableView.dataSource = self
         self.tableView.delegate = self
 
+        // FIXME: Refresh Control is not woking propery because of Scroll to Top action. Refactoring required
+        /*
         let customRefreshControl = UIRefreshControl().then {  $0.tintColor = .white }
         tableView.refreshControl = customRefreshControl
         tableView.refreshControl?.addTarget(self, action: #selector(refreshData), for: .valueChanged)
+        */
 
         // Navigation
         navigationController?.navigationBar.scrollEdgeAppearance = navigationAppearance
@@ -71,9 +75,9 @@ class ChartViewController: UIViewController {
 
         // Category Menu
         let categoryMenuItem = [
-            UIAction(title: "Popular", image: UIImage(systemName: "flame.fill"), handler: { _ in self.viewModel.requestData(category: .popular) }),
-            UIAction(title: "Top Rated", image: UIImage(systemName: "star.fill"), handler: { _ in self.viewModel.requestData(category: .topRated) }),
-            UIAction(title: "Now Playing", image: UIImage(systemName: "theatermasks.fill"), handler: { _ in self.viewModel.requestData(category: .nowPlaying) })
+            UIAction(title: "Popular", image: UIImage(systemName: "flame.fill"), handler: { _ in self.onCategoryChanged(.popular) }),
+            UIAction(title: "Top Rated", image: UIImage(systemName: "star.fill"), handler: { _ in self.onCategoryChanged(.topRated) }),
+            UIAction(title: "Now Playing", image: UIImage(systemName: "theatermasks.fill"), handler: { _ in self.onCategoryChanged(.nowPlaying) })
         ]
         let categoryMenu = UIMenu(title: "", image: nil, identifier: nil, options: [], children: categoryMenuItem)
 
@@ -92,7 +96,7 @@ class ChartViewController: UIViewController {
     private func bindData() {
         viewModel.movieListData
             .observe(on: MainScheduler.instance)
-            .subscribe(onNext: { [weak self] _ in
+            .subscribe(onNext: { [weak self] list in
                 self?.tableView.reloadData()
             })
             .disposed(by: disposeBag)
@@ -137,6 +141,16 @@ extension ChartViewController: UITableViewDelegate {
 
 }
 
+// MARK: UIMenu Callback
+extension ChartViewController {
+    private func onCategoryChanged(_ category: MovieListCategory) {
+        guard viewModel.currentCategory != category else { return }
+
+        self.viewModel.requestData(category: category)
+        self.tableView.setContentOffset(CGPoint.zero, animated: true)
+    }
+}
+
 // MARK: Scroll Features
 extension ChartViewController {
 
@@ -153,10 +167,11 @@ extension ChartViewController {
         }
 
         if category != nil { self.viewModel.refreshData() }
-        self.tableView.refreshControl?.endRefreshing()
-
     }
-
+}
+
+// MARK: Scroll Delegate methods
+extension ChartViewController {
     func scrollViewDidScroll(_ scrollView: UIScrollView) {
         let offsetY = scrollView.contentOffset.y
         let contentHeight = scrollView.contentSize.height
@@ -165,5 +180,4 @@ extension ChartViewController {
             viewModel.requestMoreData()
         }
     }
-
 }

MovieApp/MovieApp/Presentation/DetailView/View/DetailViewController.swift

@@ -235,7 +235,6 @@ extension DetailViewController {
 extension DetailViewController: UIGestureRecognizerDelegate {
 
     @objc private func backButtonAction() {
-        print(#function)
         self.navigationController?.popViewController(animated: true)
     }