Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equipment Sounds Compares NBT to decide if sounds should be played. #15

Open
Speiger opened this issue May 29, 2023 · 0 comments
Open

Comments

@Speiger
Copy link

Speiger commented May 29, 2023

This is the cause of #14 #10 #7 and those here too:
TinyModularThings/IC2Classic#721

The simple fix is basically:
Do Not match NBT, just compare items. That way small internal logic things do not play the equip sound.
If you want to be cheeky you provide a API or something that people could provide.

Anyways it would be nice if you could fix this 1 line mistake :)

if (!ItemStack.matches(newItem, oldItem)) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant