Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP Mixed content alert on using fakeimg.pl service #11

Open
viapyme opened this issue Apr 26, 2018 · 1 comment
Open

HTTP Mixed content alert on using fakeimg.pl service #11

viapyme opened this issue Apr 26, 2018 · 1 comment

Comments

@viapyme
Copy link

viapyme commented Apr 26, 2018

Hi,

Images are loaded using http when using the fakeimg.pl service. When using https, this results on a mixed content alert.

The problem is at cherry-portfolio/public/includes/classes/class-cherry-portfolio-data.php, the offending line is:
$placeholder_link = 'http://fakeimg.pl/' . $placeholder_arg['width'] . 'x' . $placeholder_arg['height'] . '/'. $placeholder_arg['background'] .'/'. $placeholder_a$
It should be:
$placeholder_link = 'https://fakeimg.pl/' . $placeholder_arg['width'] . 'x' . $placeholder_arg['height'] . '/'. $placeholder_arg['background'] .'/'. $placeholder_a$

Please fix that if you can for the next published version.

Thank you very much, best regards,

@alicam
Copy link

alicam commented Jul 29, 2018

It says everything you need to know about the Cherry people that they have not fixed this since April!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants