Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release that doesn't require git #125

Open
jenskuhrjorgensen opened this issue Jan 18, 2021 · 2 comments
Open

New release that doesn't require git #125

jenskuhrjorgensen opened this issue Jan 18, 2021 · 2 comments

Comments

@jenskuhrjorgensen
Copy link

Hi @CharlesMangwa

You've fixed package.json so that simple-markdown is installed using https://... instead of git://..., but it hasn't been released yet, which requires my CI to have git installed to use your package. I'm using it as a transitive dependency through Storybooks ondevice-notes.

Could you please release a new version with this fix?

Best regards
Jens

@ag91
Copy link

ag91 commented Nov 2, 2021

by the way, if you are using yarn it seems adding something like the following to your package.json does the trick:

"resolutions": {
    "@storybook/addon-ondevice-notes/react-native-simple-markdown": "github:CharlesMangwa/react-native-simple-markdown#pull/112/head"
  }

@FrozenPyrozen
Copy link

@CharlesMangwa pls merge pr: #112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants