Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dot/parachain): handle DistributeBitfield message #4235

Open
Tracked by #3599
haikoschol opened this issue Oct 8, 2024 · 1 comment
Open
Tracked by #3599

feat(dot/parachain): handle DistributeBitfield message #4235

haikoschol opened this issue Oct 8, 2024 · 1 comment
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review. S-subsystems-availability issues related to polkadot host availability subsystem functionality. T-implementation this issue/pr is a new feature or functionality.

Comments

@haikoschol
Copy link
Contributor

haikoschol commented Oct 8, 2024

Issue summary

#4369 should be completed before work is started on this issue.

The overseer forwards DistributeBitfield messages from other subsystems. Therefore the signature on the bitfield does not need to be checked. The message just needs to be gossiped to peers according to the following rules:

  • Ignore messages with a relay parent that's not in our view
  • Send validationprotocol.BitfieldDistributionMessage to all peers that
    • have the relay parent in their view
    • have not already received a message from us with a bitfield signed by the same validator
    • have not already sent us a message with a bitfield signed by the same validator
    • we have a route to as a local grid neighbour in the current topology
  • Send a ProvisionableDataBitfield message to the overseer

Other information and links

Parity node implementation

@haikoschol haikoschol added the S-subsystems-availability issues related to polkadot host availability subsystem functionality. label Oct 8, 2024
@haikoschol haikoschol added C-complex Complex changes across multiple modules. Possibly will require additional research. T-feat this issue/pr is a new feature or functionality. labels Dec 3, 2024
@haikoschol haikoschol changed the title feat(dot/parachain/bitfield-distribution): handle DistributeBitfield message feat(dot/parachain): handle DistributeBitfield message Dec 3, 2024
@haikoschol
Copy link
Contributor Author

Reduced estimate from 5 to 3 assuming that relay_message() will be implemented in another issue and shared between this one and #4354.

@haikoschol haikoschol added C-simple Minor changes changes, no additional research needed. Good first issue/review. and removed C-complex Complex changes across multiple modules. Possibly will require additional research. labels Dec 3, 2024
@haikoschol haikoschol added T-implementation this issue/pr is a new feature or functionality. and removed T-feat this issue/pr is a new feature or functionality. labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-simple Minor changes changes, no additional research needed. Good first issue/review. S-subsystems-availability issues related to polkadot host availability subsystem functionality. T-implementation this issue/pr is a new feature or functionality.
Projects
None yet
Development

No branches or pull requests

1 participant