Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let the developer choose the start of the week #6

Open
mikes222 opened this issue Dec 31, 2021 · 3 comments
Open

Let the developer choose the start of the week #6

mikes222 opened this issue Dec 31, 2021 · 3 comments

Comments

@mikes222
Copy link

mikes222 commented Dec 31, 2021

In some countries the week starts with monday instead of sunday. So either expose the weekdays list to the developer or let the dev choose the start of the week. The former is preferred. Maybe by exposing a List of Weekday classes instead of the current final List<Map<String, dynamic>> weekdays

@mikes222
Copy link
Author

Since there was no reaction from the orignal author I decided to refactor the library and add the missing features by myself.

@pasaneramusugoda If you like to feel free to take over the code from https://github.com/mikes222/date_time_picker_widget and deploy a new version to pub.dev.

@pasaneramusugoda
Copy link
Collaborator

@mikes222 I'm really sorry for not responding to your issue. By the way to proceed further could you please make PR. So I can merge once review and testing.

Really appreciate your time and effort on this.

@mikes222
Copy link
Author

Hi, in the meantime I refactored the library completely and added a bunch of features like the ability to deal with UTC, min/max time, callbacks and more. There are so many changes that it does not make sense for me to create a PR for specific features. But anyway if you like you are completely free to takeover my code (or parts of it). The community would appreciate it for sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants