You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@AkihisaNomoto I have noticed the following issues/improvements with JOS3.
the model does not return the mean core body temperature.
the documentation needs to be improved
we should provide an easier way to access the results. For example, using a data class.
why we can pass both the operative temperature as well as the db and mean radiant temperature
the inputs to the simulate function can be updated and renamed to improve readability and clarity. Why for example, we need to have two of them and we cannot combine them into one called duration in seconds or simulation_time to match the output? What is unclear to me is the difference from passing times=1 and dtime=60 versus times=60 and dtime=1
cycle_time is not 100% clear what it is returning
we do not need to return the pythermalcomfort version since that can be extracted from requirements.txt
we could potentially simplify the example and add a few more examples.
in the documentation it is not described how to pass the metabolic rate as an input
in the documentation it is unclear why temperature can be passed when initialising the model as well as later.
par seems to be a variable that can be passed when initialising the model but it is not. It can only be passed later when the model has already been initialised.
the unit of weight_loss_by_evap_and_res is strange since I would expect it to e the cumulative value over dtimes but the documentation says that this value is in g/s
With a weight of 74 kg, the calculated skin temperature is outside the expected physiological range (initial is 33.17°C). In contrast, using a weight of 75 kg produces reasonable results (e.g., initial is 35.02°C). A 1 kg difference shouldn't theoretically result in such significant output variation.
The text was updated successfully, but these errors were encountered:
@AkihisaNomoto I have noticed the following issues/improvements with JOS3.
simulation_time
to match the output? What is unclear to me is the difference from passingtimes
=1 anddtime
=60 versustimes
=60 anddtime
=1cycle_time
is not 100% clear what it is returningpar
seems to be a variable that can be passed when initialising the model but it is not. It can only be passed later when the model has already been initialised.dtimes
but the documentation says that this value is in g/sThe text was updated successfully, but these errors were encountered: