Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOS 3 model #150

Open
13 tasks
FedericoTartarini opened this issue Dec 17, 2024 · 0 comments
Open
13 tasks

JOS 3 model #150

FedericoTartarini opened this issue Dec 17, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@FedericoTartarini
Copy link
Collaborator

FedericoTartarini commented Dec 17, 2024

@AkihisaNomoto I have noticed the following issues/improvements with JOS3.

  • the model does not return the mean core body temperature.
  • the documentation needs to be improved
  • we should provide an easier way to access the results. For example, using a data class.
  • why we can pass both the operative temperature as well as the db and mean radiant temperature
  • the inputs to the simulate function can be updated and renamed to improve readability and clarity. Why for example, we need to have two of them and we cannot combine them into one called duration in seconds or simulation_time to match the output? What is unclear to me is the difference from passing times=1 and dtime=60 versus times=60 and dtime=1
  • cycle_time is not 100% clear what it is returning
  • we do not need to return the pythermalcomfort version since that can be extracted from requirements.txt
  • we could potentially simplify the example and add a few more examples.
  • in the documentation it is not described how to pass the metabolic rate as an input
  • in the documentation it is unclear why temperature can be passed when initialising the model as well as later.
  • par seems to be a variable that can be passed when initialising the model but it is not. It can only be passed later when the model has already been initialised.
  • the unit of weight_loss_by_evap_and_res is strange since I would expect it to e the cumulative value over dtimes but the documentation says that this value is in g/s
  • With a weight of 74 kg, the calculated skin temperature is outside the expected physiological range (initial is 33.17°C). In contrast, using a weight of 75 kg produces reasonable results (e.g., initial is 35.02°C). A 1 kg difference shouldn't theoretically result in such significant output variation.
@FedericoTartarini FedericoTartarini added the enhancement New feature or request label Dec 17, 2024
@FedericoTartarini FedericoTartarini added this to the v3 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants