From 0e70b0e0f018a127cb8543c8be5add3263fc8c89 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tobias=20Ho=CC=88=C3=9Fl?= <tobias@hoessl.eu>
Date: Sun, 17 Nov 2024 10:18:30 +0100
Subject: [PATCH] Fix some issues reported by phpstan2

---
 models/db/ConsultationUserGroup.php    |  4 ++--
 models/db/MotionSection.php            |  3 +--
 models/db/User.php                     |  1 -
 models/forms/AdminMotionFilterForm.php |  4 ++--
 models/layoutHooks/StdHooks.php        |  2 +-
 models/settings/JsonConfigTrait.php    | 11 ++---------
 plugins/ModuleBase.php                 |  1 -
 plugins/green_manager/Module.php       |  3 ---
 8 files changed, 8 insertions(+), 21 deletions(-)

diff --git a/models/db/ConsultationUserGroup.php b/models/db/ConsultationUserGroup.php
index e2dbc50435..e4c1152aed 100644
--- a/models/db/ConsultationUserGroup.php
+++ b/models/db/ConsultationUserGroup.php
@@ -138,8 +138,8 @@ public static function loadGroupsByIdForConsultation(Consultation $consultation,
     // Iterating over the userIds attached to a user group is faster than over the groupIds of a user,
     // as there are way more users, and we would need to perform more queries that way.
     // Note that this method should only be used for read-only operations, as the cache is not flushed yet.
-    /** @var null|int[][] */
-    private static ?array $userIdCache = [];
+    /** @var int[][] */
+    private static array $userIdCache = [];
 
     public function getUserIds(): array
     {
diff --git a/models/db/MotionSection.php b/models/db/MotionSection.php
index 86563fcf6f..dc3293da9f 100644
--- a/models/db/MotionSection.php
+++ b/models/db/MotionSection.php
@@ -144,9 +144,8 @@ public function getConsultation(): Consultation
             if ($motion) {
                 return Consultation::findOne($motion->consultationId);
             } else {
-                /** @var Motion $motion */
-                $section = ConsultationSettingsMotionSection::findOne($this->sectionId);
                 /** @var ConsultationSettingsMotionSection $section */
+                $section = ConsultationSettingsMotionSection::findOne($this->sectionId);
                 return $section->motionType->getConsultation();
             }
         }
diff --git a/models/db/User.php b/models/db/User.php
index 142abef515..b3bbe95506 100644
--- a/models/db/User.php
+++ b/models/db/User.php
@@ -313,7 +313,6 @@ public static function findIdentity($userId)
      * @return IdentityInterface the identity object that matches the given token.
      * Null should be returned if such an identity cannot be found
      * or the identity is not in an active state (disabled, deleted, etc.)
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public static function findIdentityByAccessToken($token, $type = null)
     {
diff --git a/models/forms/AdminMotionFilterForm.php b/models/forms/AdminMotionFilterForm.php
index 2db4116d56..18ab7833d6 100644
--- a/models/forms/AdminMotionFilterForm.php
+++ b/models/forms/AdminMotionFilterForm.php
@@ -617,7 +617,7 @@ public function getFilteredMotions(): array
                 $matches = false;
             }
 
-            if ($this->status !== null && $this->status !== '' && $motion->status !== $this->status) {
+            if ($this->status !== null && $motion->status !== $this->status) {
                 $matches = false;
             }
 
@@ -756,7 +756,7 @@ public function getFilteredAmendments(array $filteredMotions): array
                 $matches = false;
             }
 
-            if ($this->status !== null && $this->status !== "" && $amend->status !== $this->status) {
+            if ($this->status !== null && $amend->status !== $this->status) {
                 $matches = false;
             }
 
diff --git a/models/layoutHooks/StdHooks.php b/models/layoutHooks/StdHooks.php
index 82abaef648..8058035001 100644
--- a/models/layoutHooks/StdHooks.php
+++ b/models/layoutHooks/StdHooks.php
@@ -85,7 +85,7 @@ public function breadcrumbs(string $before): string
     {
         $out             = '';
         $showBreadcrumbs = (!$this->consultation || !$this->consultation->site || $this->consultation->site->getSettings()->showBreadcrumbs);
-        if (is_array($this->layout->breadcrumbs) && $showBreadcrumbs) {
+        if (count($this->layout->breadcrumbs) > 0 && $showBreadcrumbs) {
             $out .= '<nav aria-label="' . \Yii::t('base', 'aria_breadcrumb') . '"><ol class="breadcrumb">';
             foreach ($this->layout->breadcrumbs as $link => $name) {
                 if ($link === '' || is_numeric($link)) {
diff --git a/models/settings/JsonConfigTrait.php b/models/settings/JsonConfigTrait.php
index c48570af40..1f748a4ab4 100644
--- a/models/settings/JsonConfigTrait.php
+++ b/models/settings/JsonConfigTrait.php
@@ -19,15 +19,8 @@ public function __construct(null|string|array $data)
     private function propertyIsInt(\ReflectionClass $reflectionClass, string $key): bool
     {
         $propertyType = $reflectionClass->getProperty($key)->getType();
-        if (is_a($propertyType, \ReflectionNamedType::class)) {
-            $typeName = $propertyType->getName();
-        } else {
-            // Use the deprecated method in PHP <= 7.4
-            /** @var \ReflectionType $propertyType */
-            $typeName = trim($propertyType->__toString(), '?');
-        }
 
-        return $typeName === 'int';
+        return is_a($propertyType, \ReflectionNamedType::class) && $propertyType->getName() === 'int';
     }
 
     public static function decodeJson5(?string $json): ?array
@@ -81,7 +74,7 @@ protected function setPropertiesFromJSON(null|string|array $data): void
             $dataArr = self::decodeJson5($data);
         }
         if ($dataArr === null) {
-            /** @var string $data */
+            /** @var non-falsy-string $data */
             throw new ConfigurationError('Invalid JSON string: ' . $data);
         }
 
diff --git a/plugins/ModuleBase.php b/plugins/ModuleBase.php
index eb3f272d16..38523dca88 100644
--- a/plugins/ModuleBase.php
+++ b/plugins/ModuleBase.php
@@ -274,7 +274,6 @@ public static function calculateVoteResultsForApi(VotingBlock $voting, array $vo
 
     /**
      * @return class-string<VotingData>|null
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
      */
     public static function getVotingDataClass(Consultation $consultation): ?string
     {
diff --git a/plugins/green_manager/Module.php b/plugins/green_manager/Module.php
index f5784ba1f6..39a03defab 100644
--- a/plugins/green_manager/Module.php
+++ b/plugins/green_manager/Module.php
@@ -53,9 +53,6 @@ public static function getForcedLayoutHooks(Layout $layoutSettings, ?Consultatio
         ];
     }
 
-    /**
-     * @SuppressWarnings(PHPMD.UnusedFormalParameter)
-     */
     public static function getSiteSettingsClass(Site $site): string
     {
         return SiteSettings::class;