Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethernet connection as a run condition #899

Open
mikulik86 opened this issue Jul 8, 2022 · 13 comments
Open

Ethernet connection as a run condition #899

mikulik86 opened this issue Jul 8, 2022 · 13 comments

Comments

@mikulik86
Copy link

Hello and thanks to the developer.

Could you please add a ethernet connection as another run condition?
Would be great.

@Catfriend1
Copy link
Owner

What is the use case why this run condition is so important for you?

@mikulik86
Copy link
Author

I put my phone over night into a flight mode and connect it to a dock for charging and ethernet connectivity. And I want it to sync only then. Not other times when the phone is charging somewhere else where also connected to a Wi-Fi.

@Catfriend1
Copy link
Owner

I think the run condition "run in flight mode" could help you out in this scenario.

If you'd like to implement a new run condition, that would be mainly copy and paste in run condition monitor and the layout of the settings screen xml file plus some strings.

@mikulik86
Copy link
Author

I think the run condition "run in flight mode" could help you out in this scenario.

Not really. It is possible to have flight mode on and be on Wi-Fi simultaneously, which would trigger unwanted syncing.
Do you think you could implement the ethernet condition?

@Catfriend1
Copy link
Owner

Yes, I wrote how it should be done above. And no, I'm not motivated to take my time here.

@mikulik86
Copy link
Author

Unfortunately my extremely basic programming knowledge is not enough to know what exactly your instructions mean and how to do it.
It's a pity, nonetheless thanks for this otherwise great fork.

@martin-braun
Copy link

@Catfriend1 I'm not interested in the feature here, but maybe you should give people the opportunity to sponsor you through GitHub Sponsor for nice badges, etc. That could rise your motivation, even maintaining this is effort.

@martin-braun
Copy link

Would this also affect USB Tethering? In this case I am indeed interested in this feature.

@Catfriend1
Copy link
Owner

Maybe it can be achieved by third party automation tools, e.g. https://llamalab.com/automate/community/flows/41583

@mikulik86
Copy link
Author

Maybe it can be achieved by third party automation tools, e.g. https://llamalab.com/automate/community/flows/41583

Thank you, this works nice for me.
There is just one minor disadvantage: when controlled by Broadcast, force start/stop doesn't work. I suppose you wouldn't want to change it, would you?

@Catfriend1
Copy link
Owner

I could look into it. Or you suggest a PR to make the buttons available when controlled by broadcast?

@mikulik86
Copy link
Author

I would be glad if you could look into it and make your software even better.
Thanks in advance.

@Konfekt
Copy link

Konfekt commented Nov 30, 2024

While @mikulik86 got it working with

https://llamalab.com/automate/community/flows/41583

for Tasker, the following worked for me to sync it with the computer when connected to it via USB (or Wifi, which was already available as an option inside Syncthing Fork):

  1. In Tasker, add
    • two state entry tasks, one for Wifi and one for Power connect (USB or Ether didn't trigger), both triggering an Intent using package com.github.catfriend1.syncthingandroid and Broadcast com.github.catfriend1.syncthingandroid.action.START
    • a single state entry task for simultaneous Wifi and Power disconnect, triggering an Intent using package com.github.catfriend1.syncthingandroid and Broadcast com.github.catfriend1.syncthingandroid.action.STOP
  2. In Syncthing Fork, enable the experimental setting Listen to Broadcast .
  3. On the computer, make sure to have permit Syncthing's ports for the USB connection it uses

Maybe these workarounds for those syncing via other connections than WWAN/WLAN could be added to the Wiki ? It seems write locked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants