Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation is not properly updated after a category is selected #1359

Closed
ramiroaznar opened this issue Dec 13, 2019 · 5 comments · Fixed by CartoDB/airship#662
Closed

Animation is not properly updated after a category is selected #1359

ramiroaznar opened this issue Dec 13, 2019 · 5 comments · Fixed by CartoDB/airship#662

Comments

@ramiroaznar
Copy link

There is an unexpected animation behavior related to the interaction of filtering with widgets in cartoframes. After selecting one category in one widget, the time series widget histogram is redrawn but the animation does not adjust to the new state.

STR

  1. Go to https://carto.com/blog/real-estate-data-tinsa-digital/
  2. Check cartoframes map
  3. Check the animation
  4. Select a category
  5. Check again the animation

Current Result

The yellow geometries are popping up ca. 1971.

1

After 1971-1980 category is selected. The histogram of the time series widget is redrawn. But the animation is still behaving as nothing has been filtered. The geometries appear not in 1971 based on the current state of the widget, but around 1977. If you check it is the same point that the 1971 mark was set in the previous state.

2

Expected Result

The geometries should start popping up at the very beggining of the animation (bar) after the selection.

Environment

Ubuntu 18
Chrome v79

@ramiroaznar
Copy link
Author

ramiroaznar commented Jan 9, 2020

Hey @elenatorro, checking on the blogpost map it does not seem the issue is fixed (maybe the map is on a different version though...).

@elenatorro
Copy link
Contributor

This issue was closed automatically after the merge, sorry. The solution will be included in the next Airship release.

@elenatorro
Copy link
Contributor

elenatorro commented Jan 9, 2020

Opened issue for RT in the blog repo https://github.com/CartoDB/blog/issues/1638

@elenatorro elenatorro removed their assignment Jan 13, 2020
@Jesus89 Jesus89 assigned elenatorro and unassigned elenatorro Jan 13, 2020
@ramiroaznar
Copy link
Author

ramiroaznar commented Jan 23, 2020

I dont see any improvements in the blog post (the geometries have changed though). Maybe the cartoframe animation was done by a previous version...

cartoframes

@elenatorro
Copy link
Contributor

Hi @ramiroaznar :) As you said, the animation has changed. This specific issue has been solved, but it's true that we need to be able to configure the animation through CARTOframes. In this blog post example, the problem is that the animation doesn't hold.

For this purpose, we've opened this issue, in order to use an animation helper in the styles.

Thank you very much! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants