Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram max value keeps changing even though the global max is still in view #653

Open
andy-esch opened this issue Sep 11, 2019 · 4 comments
Assignees

Comments

@andy-esch
Copy link

What is happening?
The max value in the histogram changes (going lower) even though a 'higher' max value is still in view.
histogram-max-value

What should happen?
In this case, the max value is 1 and the histogram should keep the x-axis on 1 the entire time because that geometry is still in view.

Steps to Reproduce
I can set you up with the data/map offline.

Device/Browser/Airship-Version
Version 76.0.3809.100 (Official Build) (64-bit)
cartoframes version in develop as of Sept 11

Extra information
Nope, let me know how I can help. Thanks!

@VictorVelarde
Copy link
Contributor

@elenatorro Same as in #157, feel free to ping RT for this one

@VictorVelarde
Copy link
Contributor

Please @CartoDB/rt-managers add this to RT

@rjimenezda
Copy link
Contributor

Almost positive this is a VL aggregations issue, but we can investigate.

@makella
Copy link

makella commented Sep 17, 2019

I'm pretty sure this is due to the global vs. viewport aggregations and the values that VL returns. @elenatorro and I had this discussion when we were working on the globalHistogram expression.

From the globalHistogram PR:

For numeric values, we're using the sample values from the metadata, as we're doing in other global expressions such as GlobalQuantiles. As we've discussed, we'll talk about it during this cycle.

@elenatorro elenatorro self-assigned this Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants