Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for CARTO VL version on Airship Bridge 2.2 #645

Open
rjimenezda opened this issue Aug 22, 2019 · 1 comment
Open

Add check for CARTO VL version on Airship Bridge 2.2 #645

rjimenezda opened this issue Aug 22, 2019 · 1 comment

Comments

@rjimenezda
Copy link
Contributor

Problem
We can encounter some issues with the bridge and CARTO VL < 1.3, particularly regarding getLegendData

Proposed solution
Check the CARTO VL version when using the Legends bridge. The "filters" part of the bridge probably doesn't need it.

Might have an issue getting the actual version, since we're just passing the layer itself. Maybe we can do some feature detection instead 🤔

Extra info
...

@elenatorro elenatorro self-assigned this Aug 26, 2019
@elenatorro
Copy link
Contributor

I think this is not a priority at the moment. If we found there's any user complaint, we can add the warning. Let's leave it open for now 👍

@elenatorro elenatorro removed their assignment Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants