Deprecate clib 'xyz_newFromFile' from CLib

[ischoegl]

Abstract

Historically, ThermoPhase and Kinetics objects were instantiated in the clib API via thermo_newFromFile and kin_newFromFile. Cantera/cantera#1448 introduced access for Solution objects to clib, which can now be instantiated via soln_newSolution (and soln_newInterface).

The historic instantiation route was important for the (now removed) legacy MATLAB toolbox, but is also still actively used in the Fortran and .NET interfaces. The main advantage of the new clib API functions is that they (i) allow for handling that is consistent with other parts of Cantera, and (ii) take care of all configuration steps.

Motivation

Describe the need for the proposed change:

• What problem is it trying to solve? ... make handling of Solution consistent across all interfaces
• Who is affected by the change? ... users of clib and derived APIs (e.g .NET)
• Why is this a good solution? ... removes legacy code

Edit: Fortran is not affected by CLib, as it reimplements the _newFromFile routines separately.

Possible Solutions

Remove all instances of thermo_newFromFile and kin_newFromFile, and replace them by single call to soln_newSolution. Inclusion of surface kinetics in .NET requires resolution of Cantera/cantera#1450.

References

• Smart clib cabinets / add Solution to clib API cantera#1448
• sourcegen fails to process clib signature cantera#1450
• Remove legacy MATLAB toolbox cantera#1670

[ischoegl]

As a first step, the new MATLAB toolbox should use soln_newSolution exclusively
https://github.com/Cantera/cantera/blob/eadfec4bf398c3038b20c17fcccfcd289eb384cd/interfaces/matlab_experimental/Base/Solution.m#L78
with
https://github.com/Cantera/cantera/blob/eadfec4bf398c3038b20c17fcccfcd289eb384cd/interfaces/matlab_experimental/Base/ThermoPhase.m#L445
and
https://github.com/Cantera/cantera/blob/eadfec4bf398c3038b20c17fcccfcd289eb384cd/interfaces/matlab_experimental/Base/Kinetics.m#L143
being removed.