Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing functors in matlab toolbox #567

Closed
ghost opened this issue Oct 17, 2018 · 2 comments · Fixed by #1741
Closed

Missing functors in matlab toolbox #567

ghost opened this issue Oct 17, 2018 · 2 comments · Fixed by #1741
Labels

Comments

@ghost
Copy link

ghost commented Oct 17, 2018

Cantera version

2.4.0

Operating System

Win10

Python/MATLAB version

Matlab2016b

Expected Behavior

func = Func('pow', base, exponent);
-> func = base^exponent

Actual Behavior

Pow-Functor and other functors are missing in Matlab Toolbox (https://groups.google.com/forum/#!searchin/cantera-users/matlab$20functor$20in$20matlab%7Csort:date/cantera-users/jBWBBjilFxg/ilkOCfwoBgAJ).

Steps to reproduce

omega = 1500/30pi;
offset = 263/180
pi;
ct.x = Func('polynomial', 1, [omega -offset]);
ct.func = Func('pow', ct.x, 0.5);

Also not working to arbitrarily combine functors

ct.sin = Func('fourier', ct.x, 1, [0 0 omega 1]);
-> ct.sin = sin(Omega*x-Offset)

@speth speth added the Matlab label Oct 17, 2018
@ischoegl
Copy link
Member

PR #1513 implements factory constructors for Func1 objects that avoids hard-coding of functor names (or corresponding magic numbers).

@ischoegl
Copy link
Member

ischoegl commented Jul 28, 2024

After removal of the legacy MATLAB toolbox via #1670, all functors will be supported in the experimental toolbox after #1741.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants