Reviewed 24 of 24 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @jolevesq)

packages/geoview-core/src/api/event-processors/event-processor-children/time-slider-event-processor.ts line 131 at r1 (raw file):

    // Cast the layer
    const geoviewLayerCasted = geoviewLayer as AbstractGVLayer | AbstractGVLayer;

Ici, on peut enlever la redondance

packages/geoview-core/src/geo/layer/geoview-layers/vector/abstract-geoview-vector.ts line 337 at r1 (raw file):

  protected createVectorLayer(layerConfig: VectorLayerEntryConfig, vectorSource: VectorSource): VectorLayer<Feature> {
    // GV Time to request an OpenLayers layer!
    const requestResult = this.emitLayerRequesting({ config: layerConfig, source: vectorSource });

There may be some additional enhancements to be done now that we can notice how emitLayerRequesting and emitLayerCreation are getting "close" to each other. Like merging them into one maybe? Food for thought.

packages/geoview-core/src/geo/layer/layer-sets/all-feature-info-layer-set.ts line 113 at r1 (raw file):

      // If layer was found
      if (layer && (layer instanceof AbstractGeoViewLayer || layer instanceof AbstractGVLayer)) {

The AbstractGeoViewLayer can probably be removed here (and in all other similar places in the other layer sets classes).
In fact, a code search for AbstractGeoViewLayer should be made to likely remove pending unnecessary ones.

packages/geoview-core/src/geo/layer/geoview-layers/raster/esri-dynamic.ts line 409 at r1 (raw file):

   */
  // GV Layers Refactoring - Obsolete (in layers)
  protected override getFeatureInfoAtPixel(location: Pixel, layerPath: string): Promise<TypeFeatureInfoEntry[] | undefined | null> {

Should we remove ALL the methods flagged with Obsolete (in layers) functions from all the "old geoview-layers" classes as part of this PR or are we waiting?

There are a whole lot of those.

packages/geoview-core/src/geo/layer/layer.ts line 1498 at r1 (raw file):

    if (!layerEntryIsGroupLayer(layerConfig)) {
      // Get the layer
      const layer = this.getGeoviewLayer(layerConfig.layerPath) as AbstractGeoViewLayer | AbstractGVLayer;

Should probably remove AbstractGeoViewLayer here

packages/geoview-core/src/geo/layer/layer-sets/feature-info-layer-set.ts line 137 at r1 (raw file):

      // If layer was found
      if (layer && (layer instanceof AbstractGeoViewLayer || layer instanceof AbstractGVLayer)) {

(like here)

Reviewable status: 3 of 38 files reviewed, 6 unresolved discussions (waiting on @Alex-NRCan)

packages/geoview-core/src/api/event-processors/event-processor-children/time-slider-event-processor.ts line 131 at r1 (raw file):

Done.

packages/geoview-core/src/geo/layer/layer.ts line 1498 at r1 (raw file):

Done.

packages/geoview-core/src/geo/layer/geoview-layers/raster/esri-dynamic.ts line 409 at r1 (raw file):

Yes, this draft PR was just the first step. I will do part of another commit

packages/geoview-core/src/geo/layer/geoview-layers/vector/abstract-geoview-vector.ts line 337 at r1 (raw file):

Added a comment