Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can you increase the function of multi-finger zooming in pictures? #578

Open
showdy opened this issue Jul 4, 2023 · 12 comments
Open

Can you increase the function of multi-finger zooming in pictures? #578

showdy opened this issue Jul 4, 2023 · 12 comments

Comments

@showdy
Copy link

showdy commented Jul 4, 2023

No description provided.

@showdy
Copy link
Author

showdy commented Jul 4, 2023

20230704-195135.mp4

@vanniktech
Copy link
Contributor

I don't get it.

@showdy
Copy link
Author

showdy commented Jul 5, 2023

I don't get it.

In the example, the multi touch function is used, but the effect seems to have some problems. Can the effect of multi-touch be optimized as shown in the video above.

@vanniktech
Copy link
Contributor

Optimized in which way?

@RahulSDeshpande
Copy link

RahulSDeshpande commented Sep 18, 2023

@vanniktech I guess, @showdy means, does this library support cropping using zoom in/out on the image?

Am I right @showdy? 🤔

@MathiasDL
Copy link

MathiasDL commented Apr 16, 2024

Multitouch zooming during cropping would indeed be a great addition to this library! Note that the multiTouchEnabled exists, but it is very buggy in my experience:

  1. It seems to conflict with adjusting the crop area. Once multitouch is detected, only zoom should be active
  2. fixAspectRatio is not respected when multitouch is enabled

Turning off autoZoomEnabled reduces these issues a bit, but autozoom is a great feature

I may try to fix this in the library and create a PR

@vanniktech
Copy link
Contributor

PRs are welcome!

@vanniktech
Copy link
Contributor

@MathiasDL have you had any time to look at this?

@MathiasDL
Copy link

MathiasDL commented Aug 21, 2024

@vanniktech I am currently converting my app to Kotlin Multiplatform (KMP), which is not compatible with this library, so I won't be implementing this...

@vanniktech
Copy link
Contributor

What do you use for image cropping? I also have a KMP library and I use this library on the Android side and Mantis on iOS.

@MathiasDL
Copy link

I am considering this library: CMP-image-pick-n-crop. If it is not good enough, I will probably follow your approach. I will know in a couple of weeks when I get to that point in the conversion

@MathiasDL
Copy link

@vanniktech FYI, I went with https://github.com/tamimattafi/krop (KMP fork of easycrop)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants