MP4 support & Direct downloads

[That-Guy-Jack]

Hi was wondering what i need to change to make the downloads be .mp4 rather than .mkv as mp4 is supported with discord and other platforms natively. i've tried changing the file type in backend/src/youtube_archiver/downloader.py (line 208) to .mp4 but that made the download not have audio so not sure what else needs changing.

also is there a way to make the download button just download the file rather than taking you to the directory?

Thanks
Jack

[Caligatio]

It should be relatively easy for it to churn out a MP4 but I'll have to experiment a bit to remember what would need to change.

I can also take a look at maybe adding individual links for video and audio as that probably wouldn't be too cluttered (I actually made this for a family member and tried to make it simple to use).

Unfortunately I'm in the midst of an international move so my ability to do any work is hampered by my lack of good internet and any furniture :) It might take me a few weeks before I can dig into this.

[That-Guy-Jack]

Sounds Good good luck with the move, ill see if i can do some tinkering in the mean time :D

[That-Guy-Jack]

Been messing around with the code for about 30 mins now made a daft patch for the direct download button css might need tweaking a bit but it works

I'll upload it to a git repo now and ill drop a link in here once its done

[That-Guy-Jack]

Made A Fork here in the mean time i'll look into the mp4 support

https://github.com/That-Guy-Jack/youtube-archiver

[That-Guy-Jack]

managed to get some videos to work with the mp4 set as the "merge_output_format" in the downloader.py but most videos had no audio but normal video so not sure what is wrong there

[That-Guy-Jack]

Any Updates @Caligatio ?

[Caligatio]

Still living out of suitcases and using my phone as my primary computing device. I do have a date for my stuff to be delivered and hope to take a look at this sometime next month!

[That-Guy-Jack]

any updates on this : )

[Caligatio]

Do you have an example of a video (a link) that is lacking audio? It should always be grabbing audio and doing a merge if necessary.