Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vs in COSTALD_compressed should be Vsat? #43

Open
jgostick opened this issue Jul 14, 2022 · 0 comments
Open

Vs in COSTALD_compressed should be Vsat? #43

jgostick opened this issue Jul 14, 2022 · 0 comments

Comments

@jgostick
Copy link

jgostick commented Jul 14, 2022

In the COSTALD_compressed method, and perhaps others, there is an argument Vs for saturation volume. It was my impression that the suffix s on an argument name meant plural as in the properties of each component in the mixture. I am trying to write a wrapper for these functions, and have been relying on this implied API (any arg ending with s triggers a look-up of properties from multiple phases). I think this Vs should be Vsat. Also, I hope that am correct about you reserving the s suffix for mixture properties because this is quite handy. If this is just a loose convention, might I suggest or request that you consider making it a hard-coded fact?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant