From 6849291ccb7b2ac2979827f6e89a2a84b74834d6 Mon Sep 17 00:00:00 2001 From: Caius-Bonus <123886836+Caius-Bonus@users.noreply.github.com> Date: Mon, 2 Oct 2023 08:43:57 +0200 Subject: [PATCH] improve entity names --- homeassistant/components/zha/number.py | 4 ++-- homeassistant/components/zha/select.py | 2 +- homeassistant/components/zha/sensor.py | 6 +++--- homeassistant/components/zha/switch.py | 12 ++++++------ 4 files changed, 12 insertions(+), 12 deletions(-) diff --git a/homeassistant/components/zha/number.py b/homeassistant/components/zha/number.py index 6c9d90e54c4c0f..7fff6774dd3beb 100644 --- a/homeassistant/components/zha/number.py +++ b/homeassistant/components/zha/number.py @@ -1034,7 +1034,7 @@ class DanfossExerciseTriggerTime( """Danfoss Proprietary Attribute to set the time to exercise the valve.""" _zcl_attribute: str = "exercise_trigger_time" - _attr_name: str = "Exercise Trigger Time" + _attr_name: str = "Exercise Start Time" _attr_native_min_value: int = 0 _attr_native_max_value: int = 1439 _attr_mode: NumberMode = NumberMode.BOX @@ -1053,7 +1053,7 @@ class DanfossExternalMeasuredRoomSensor( """Danfoss Proprietary Attribute to communicate the value of the external temperature sensor.""" _zcl_attribute: str = "external_measured_room_sensor" - _attr_name: str = "External Measured Room Sensor" + _attr_name: str = "External Temperature Sensor" _attr_native_min_value: float = -80 _attr_native_max_value: float = 35 _attr_icon: str = "mdi:thermometer" diff --git a/homeassistant/components/zha/select.py b/homeassistant/components/zha/select.py index a60d36edba9b02..4735f0e8862174 100644 --- a/homeassistant/components/zha/select.py +++ b/homeassistant/components/zha/select.py @@ -663,7 +663,7 @@ class DanfossAdaptationRunControl( """Danfoss Proprietary attribute for controlling the current adaptation run.""" _select_attr = "adaptation_run_control" - _attr_name: str = "Adaptation Run Control" + _attr_name: str = "Adaptation Run Command" _enum = DanfossAdaptationRunControlEnum diff --git a/homeassistant/components/zha/sensor.py b/homeassistant/components/zha/sensor.py index bb1d47a45d43fb..1e0de80b39c7f2 100644 --- a/homeassistant/components/zha/sensor.py +++ b/homeassistant/components/zha/sensor.py @@ -1109,7 +1109,7 @@ class DanfossOpenWindowDetection(Sensor, id_suffix="open_window_detection"): """ SENSOR_ATTR = "open_window_detection" - _attr_name: str = "Open Window Detection" + _attr_name: str = "Open Window Detected" _attr_icon: str = "mdi:window-open" _attr_device_class: SensorDeviceClass = SensorDeviceClass.ENUM @@ -1185,7 +1185,7 @@ class DanfossSoftwareErrorCode(Sensor, id_suffix="sw_error_code"): """Danfoss Proprietary attribute for communicating the error code.""" SENSOR_ATTR = "sw_error_code" - _attr_name: str = "Software Error Code" + _attr_name: str = "Software Error" _attr_entity_category = EntityCategory.DIAGNOSTIC def formatter(self, _value: int) -> str: @@ -1229,5 +1229,5 @@ class DanfossMotorStepCounter(Sensor, id_suffix="motor_step_counter"): """Danfoss Proprietary attribute for communicating the motor step counter.""" SENSOR_ATTR = "motor_step_counter" - _attr_name: str = "Motor step counter" + _attr_name: str = "Motor Stepcount" _attr_entity_category = EntityCategory.DIAGNOSTIC diff --git a/homeassistant/components/zha/switch.py b/homeassistant/components/zha/switch.py index 1991902fed81ed..fd725bdb529c5c 100644 --- a/homeassistant/components/zha/switch.py +++ b/homeassistant/components/zha/switch.py @@ -600,7 +600,7 @@ class DanfossExternalOpenWindowDetected( """Danfoss Proprietary attribute for communicating an open window.""" _zcl_attribute: str = "external_open_window_detected" - _attr_name: str = "External Open Window Detected" + _attr_name: str = "External Window Open" _attr_icon: str = "mdi:window-open" @@ -614,7 +614,7 @@ class DanfossWindowOpenFeature( """Danfoss Proprietary attribute enabling open window detection.""" _zcl_attribute: str = "window_open_feature" - _attr_name: str = "Window Open Feature" + _attr_name: str = "Use Window Open Detection" _attr_icon: str = "mdi:window-open" @@ -628,7 +628,7 @@ class DanfossMountingModeControl( """Danfoss Proprietary attribute for switching to mounting mode.""" _zcl_attribute: str = "mounting_mode_control" - _attr_name: str = "Mounting Mode Control" + _attr_name: str = "Mounting Mode" @CONFIG_DIAGNOSTIC_MATCH( @@ -641,7 +641,7 @@ class DanfossRadiatorCovered( """Danfoss Proprietary attribute for communicating full usage of the external temperature sensor.""" _zcl_attribute: str = "radiator_covered" - _attr_name: str = "Radiator Covered" + _attr_name: str = "Use External Temperature Sensor" _attr_icon: str = "mdi:thermometer" @@ -667,7 +667,7 @@ class DanfossLoadBalancingEnable( """Danfoss Proprietary attribute for enabling load balancing.""" _zcl_attribute: str = "load_balancing_enable" - _attr_name: str = "Load Balancing Enable" + _attr_name: str = "Use Load Balancing" _attr_icon: str = "mdi:scale-balance" @@ -684,4 +684,4 @@ class DanfossAdaptationRunSettings( """ _zcl_attribute: str = "adaptation_run_settings" - _attr_name: str = "Adaptation Run Settings" + _attr_name: str = "Adaptation Run Enabled"