Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$C25 returned to GPCR #305

Closed
hbcam opened this issue Apr 8, 2016 · 3 comments
Closed

$C25 returned to GPCR #305

hbcam opened this issue Apr 8, 2016 · 3 comments

Comments

@hbcam
Copy link
Contributor

hbcam commented Apr 8, 2016

$C25 is now a general purpose register.

'ReservedCheriRegs' still contains it.

https://github.com/CTSRD-CHERI/llvm/blob/master/lib/Target/Mips/MipsRegisterInfo.cpp

  static const uint16_t ReservedCheriRegs[] = {
    Mips::C0, Mips::C25, Mips::C26, Mips::C27, Mips::C28, Mips::C29, Mips::C30,
    Mips::C31
  };

Would it be a good idea to add it to the callee-save registers?

@davidchisnall
Copy link
Member

I think that we're currently shorter of caller-save than callee-save registers, so probably better to use it there. Just deleting it from this enum should do that.

@hbcam
Copy link
Contributor Author

hbcam commented Apr 8, 2016

Done in #158 .

@arichardson arichardson transferred this issue from CTSRD-CHERI/llvm Mar 13, 2019
@arichardson
Copy link
Member

No further improvements to CHERI-MIPS planned.

@arichardson arichardson closed this as not planned Won't fix, can't repro, duplicate, stale Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants